Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ho): honor deprecated global config fields #1631

Merged
merged 1 commit into from
Aug 1, 2022
Merged

fix(ho): honor deprecated global config fields #1631

merged 1 commit into from
Aug 1, 2022

Conversation

hasueki
Copy link
Contributor

@hasueki hasueki commented Jul 29, 2022 •
edited
Loading

What this PR does / why we need it:
Fixes #1630

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #1630

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci bot requested review from alvaroaleman and enxebre July 29, 2022 15:00
@hasueki hasueki force-pushed the fix-global-config-deprecation branch 2 times, most recently from 4dd4def to 959c647 Compare July 29, 2022 16:05
@hasueki hasueki force-pushed the fix-global-config-deprecation branch 3 times, most recently from 74827cb to d99abfa Compare July 30, 2022 15:21
@netlify
Copy link

netlify bot commented Jul 30, 2022 •
edited
Loading

✅ Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit 916e45b
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/62e6ea424f979600089bc875
😎 Deploy Preview https://deploy-preview-1631--hypershift-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@hasueki hasueki force-pushed the fix-global-config-deprecation branch 3 times, most recently from f565225 to e736dad Compare July 31, 2022 00:51
@hasueki
Copy link
Contributor Author

hasueki commented Jul 31, 2022

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2022
@hasueki hasueki force-pushed the fix-global-config-deprecation branch 4 times, most recently from 916e45b to fb93295 Compare July 31, 2022 21:49
@hasueki hasueki force-pushed the fix-global-config-deprecation branch from fb93295 to c320791 Compare July 31, 2022 23:00
@hasueki
Copy link
Contributor Author

hasueki commented Jul 31, 2022

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2022
@hasueki hasueki requested a review from csrwng July 31, 2022 23:08
hasueki
hasueki commented Jul 31, 2022
View reviewed changes
support/globalconfig/globalconfig.go
Comment on lines +55 to +59
if obj.Spec.Audit.Profile == "" {
// Populate kubebuilder default for comparison
// https://github.com/openshift/api/blob/f120778bee805ad1a7a4f05a6430332cf5811813/config/v1/types_apiserver.go#L57
obj.Spec.Audit.Profile = configv1.DefaultAuditProfileType
}
Copy link
Contributor Author

@hasueki hasueki Jul 31, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit of explanation on this: Raw yaml is decoded as audit: {}, but is compared against audit: { Profile: Default } because of the default being set. Without this, reconciliation stalls later on.

@csrwng
Copy link
Contributor

csrwng commented Aug 1, 2022

/lgtm
/retest-required
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, hasueki

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD eef8269 and 8 for PR HEAD c320791 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 1 against base HEAD eef8269 and 7 for PR HEAD c320791 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 1, 2022

@hasueki: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/capi-provider-agent-sanity c320791 link false /test capi-provider-agent-sanity

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 1792285 into openshift:main Aug 1, 2022
@a-dsouza a-dsouza mentioned this pull request Apr 5, 2023
Closed
4 tasks
@a-dsouza a-dsouza mentioned this pull request Apr 27, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaroaleman alvaroaleman Awaiting requested review from alvaroaleman

@enxebre enxebre Awaiting requested review from enxebre

@csrwng csrwng Awaiting requested review from csrwng

Assignees

@csrwng csrwng

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecated global config can only be applied once
4 participants
@hasueki @csrwng @openshift-ci-robot @openshift-merge-robot