Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E etcd tests: Always run on none platform #1629

Merged
merged 1 commit into from
Jul 31, 2022

Conversation

alvaroaleman
Copy link
Contributor

These tests only test etcd behavior which is the same regardless of
platform. Run them on the none platform to speed things up and avoid
needlessly creating cloud provider resources.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci bot requested review from enxebre and sjenning July 29, 2022 03:56
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2022
These tests only test etcd behavior which is the same regardless of
platform. Run them on the none platform to speed things up and avoid
needlessly creating cloud provider resources.
@alvaroaleman
Copy link
Contributor Author

/cc @csrwng

@openshift-ci openshift-ci bot requested a review from csrwng July 29, 2022 16:21
@eranco74
Copy link
Contributor

/test capi-provider-agent-sanity
Just making sure the test is fixed

@csrwng
Copy link
Contributor

csrwng commented Jul 31, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 586b0aa and 8 for PR HEAD fe47043 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 1 against base HEAD 586b0aa and 7 for PR HEAD fe47043 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 31, 2022

@alvaroaleman: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 7e3cd37 into openshift:main Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants