Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set condition messsage when waiting for kas readiness #1627

Merged
merged 1 commit into from
Jul 29, 2022
Merged

set condition messsage when waiting for kas readiness #1627

merged 1 commit into from
Jul 29, 2022
+27 −16

Conversation

sjenning
Copy link
Contributor

@sjenning sjenning commented Jul 28, 2022 •
edited
Loading

What this PR does / why we need it:
https://issues.redhat.com/browse/HOSTEDCP-492

Set condition message when waiting for KAS readiness.

It also changes the wording of some reasons and messages from "unavailable" to "waiting" for better UX, conveying that nothing is wrong (probably) and that things are likely just still progressing.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci bot requested review from csrwng and enxebre July 28, 2022 20:28
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2022
@csrwng
Copy link
Contributor

csrwng commented Jul 28, 2022

/lgtm
thx!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 8e82b88 and 8 for PR HEAD efb0790 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 1cb59dd and 7 for PR HEAD efb0790 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 29, 2022

@sjenning: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/capi-provider-agent-sanity efb0790 link false /test capi-provider-agent-sanity

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 964f03f into openshift:main Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csrwng csrwng Awaiting requested review from csrwng

@enxebre enxebre Awaiting requested review from enxebre

Assignees

@csrwng csrwng

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sjenning @csrwng @openshift-ci-robot @openshift-merge-robot