Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PowerVS: upgrade capi image #1618

Merged
merged 1 commit into from
Jul 27, 2022
Merged

PowerVS: upgrade capi image #1618

merged 1 commit into from
Jul 27, 2022

Conversation

dharaneeshvrd
Copy link
Member

What this PR does / why we need it:

Trying to upgrade capi image.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci bot requested review from alvaroaleman and enxebre July 27, 2022 06:46
@dharaneeshvrd
Copy link
Member Author

/cc @mkumatag

@openshift-ci openshift-ci bot requested a review from mkumatag July 27, 2022 07:03
mkumatag
mkumatag suggested changes Jul 27, 2022
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update the go.mod as well

@dharaneeshvrd dharaneeshvrd force-pushed the powervs-capi-upgrade branch from d1ab6ec to aa8300c Compare July 27, 2022 07:10
@dharaneeshvrd
Copy link
Member Author

Let's update the go.mod as well

Updated @mkumatag

mkumatag
mkumatag approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2022
@mkumatag
Copy link
Member

/assign @enxebre @alvaroaleman

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, dharaneeshvrd, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 579d83b and 8 for PR HEAD aa8300c in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 27, 2022

@dharaneeshvrd: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 917c954 into openshift:main Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag approved these changes

@alvaroaleman alvaroaleman alvaroaleman approved these changes

@enxebre enxebre Awaiting requested review from enxebre

Assignees

@enxebre enxebre

@alvaroaleman alvaroaleman

@mkumatag mkumatag

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dharaneeshvrd @mkumatag @openshift-ci-robot @alvaroaleman @enxebre @openshift-merge-robot