Remove .status from serialized configuration on HCP #1617
Conversation
In the typed configuration we store, we only use the spec struct of each configuration resource. However, when we serialize it, we include the entire resource. The stauts resource is not needed and is causing incompatibility with older OCP versions. Going forward, the incompatibility should be fixed by openshift#1616. However, this change is needed to ensure we don't immediately break things while CPOs in production are upgraded.
openshift-ci
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, csrwng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
major props to the kube wizardry done here :) |
|
/retest |
|
see change: openshift/api#1235 that sparked this change for more details |
|
/skip |
|
@csrwng: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What this PR does / why we need it:
In the typed configuration we store, we only use the spec struct of each
configuration resource. However, when we serialize it, we include the
entire resource. The stauts resource is not needed and is causing
incompatibility with older OCP versions.
Going forward, the incompatibility should be fixed by #1616. However,
this change is needed to ensure we don't immediately break things while
CPOs in production are upgraded.
Checklist