Introduce node selector support for HostedClusters #1592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
✅ Deploy Preview for hypershift-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
enxebre
force-pushed
the
cp-infra-nodes
branch
2 times, most recently
from
dec42a0 to
9af7e83
Compare
|
/test verify |
|
/retest |
zanetworker
reviewed
Jul 21, 2022
| In addition: | ||
| - Pods for a Hosted Cluster prefer to be scheduled into the same Node. | ||
| - If the `ControllerAvailabilityPolicy` is `HighlyAvailable` Pods for each Deployment within a Hosted Cluster will require to be scheduled across different failure domains by setting `topology.kubernetes.io/zone` as the topology key. | ||
| - A HostedCluster can require their Pods to be scheduled into particlar Nodes by setting `HostedCluster.spec.nodeSelector`. |
There was a problem hiding this comment.
Do you think it makes sense to give examples here for infra nodes?
enxebre
force-pushed
the
cp-infra-nodes
branch
2 times, most recently
from
26d3c0f to
fb4e842
Compare
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
enxebre
force-pushed
the
cp-infra-nodes
branch
2 times, most recently
from
b296d06 to
779669e
Compare
|
/retest |
1 similar comment
|
/retest |
csrwng
reviewed
Jul 22, 2022
support/config/deployment.go
Outdated
| c.setNodeSelector(hcp) | ||
| c.setControlPlaneIsolation(hcp) | ||
| c.setColocation(hcp) | ||
| c.setMultizoneSpread(multiZoneSpreadLabels) |
There was a problem hiding this comment.
This should only be called if the deployment has replicas > 1, otherwise it prevents single replica deployment rollouts.
enxebre
force-pushed
the
cp-infra-nodes
branch
5 times, most recently
from
82fab47 to
43b16e3
Compare
|
/test e2e-aws |
|
/test e2e-aws-nested |
2 similar comments
|
/test e2e-aws-nested |
|
/test e2e-aws-nested |
|
/test unit |
|
@enxebre: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test e2e-aws-nested |
This enables the use case where we want all product workloads to be allocated into infra nodes. The PR includes refactor of support/config/deployment: - Make setControlPlaneIsolation, setColocation and setMultizoneSpread private. - Introduces atomic public setLocation. - Introduces setReplicas. - Introduces public setDefaults. - Clarify comments and structured based on PodAfinnity vs NodeAfinnity. - Add unit test for setLocation. - Update docs.
|
/test unit |
1 similar comment
|
/test unit |
|
/lgtm |
enxebre
added a commit
to enxebre/hypershift
that referenced
this pull request
Aug 3, 2022
Following up to openshift#1592, this keeps refactoring dropping hypershif-operator/util in favour of support/ and consolidates legacy HO reconciliation for mapprover and autoscaler with PCO reconciliation.
enxebre
added a commit
to enxebre/hypershift
that referenced
this pull request
Aug 3, 2022
Following up to openshift#1592, this keeps refactoring dropping hypershif-operator/util in favour of support/ and consolidates legacy HO reconciliation for mapprover and autoscaler with PCO reconciliation.
enxebre
added a commit
to enxebre/hypershift
that referenced
this pull request
Aug 3, 2022
Following up to openshift#1592, this keeps refactoring dropping hypershif-operator/util in favour of support/ and consolidates legacy HO reconciliation for mapprover and autoscaler with PCO reconciliation.
4 tasks
enxebre
added a commit
to enxebre/hypershift
that referenced
this pull request
Aug 3, 2022
Following up to openshift#1592, this keeps refactoring dropping hypershif-operator/util in favour of support/ and consolidates legacy HO reconciliation for mapprover and autoscaler with PCO reconciliation.
enxebre
added a commit
to enxebre/hypershift
that referenced
this pull request
Aug 3, 2022
Following up to openshift#1592, this keeps refactoring dropping hypershif-operator/util in favour of support/ and consolidates legacy HO reconciliation for mapprover and autoscaler with PCO reconciliation.
enxebre
added a commit
to enxebre/hypershift
that referenced
this pull request
Aug 4, 2022
Following up to openshift#1592, this keeps refactoring dropping hypershif-operator/util in favour of support/ and consolidates legacy HO reconciliation for mapprover and autoscaler with PCO reconciliation.
enxebre
added a commit
to enxebre/hypershift
that referenced
this pull request
Aug 4, 2022
Following up to openshift#1592, this keeps refactoring dropping hypershif-operator/util in favour of support/ and consolidates legacy HO reconciliation for mapprover and autoscaler with PCO reconciliation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This enables the use case where we want all product workloads to be allocated into infra nodes.
The PR includes refactor of support/config/deployment:
Follow up refactor:
Some considerations:
Instead of proposed plain map[string]string nodeSelector, do we prefer a nodePlacement field so we preserve our ability to extend it in the future?
Which issue(s) this PR fixes *(optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)format, where https://issues.redhat.com/browse/HOSTEDCP-506Checklist