Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Degraded condition to HCP #1560

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

sjenning
Copy link
Contributor

What this PR does / why we need it:
Requires #1554
https://issues.redhat.com/browse/HOSTEDCP-495

Adds a Degraded condition on the HCP with Reason UnavailableReplicas if any of the CPO managed deployments has a status.unavailableReplicas > 0.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci openshift-ci bot requested review from alvaroaleman and csrwng July 13, 2022 16:57
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2022
@netlify
Copy link

netlify bot commented Jul 13, 2022

Deploy Preview for hypershift-docs ready!

Name Link
🔨 Latest commit 76528e7
🔍 Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/62cef95aaa56930009d02828
😎 Deploy Preview https://deploy-preview-1560--hypershift-docs.netlify.app/reference/api
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sjenning sjenning force-pushed the hcp-degraded-condition branch from 76528e7 to 1b5ec4a Compare July 13, 2022 20:33
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 13, 2022
@sjenning sjenning force-pushed the hcp-degraded-condition branch from 1b5ec4a to 098243e Compare July 13, 2022 20:41
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 13, 2022
@csrwng
Copy link
Contributor

csrwng commented Jul 14, 2022

/retest

@sjenning
Copy link
Contributor Author

/retest-required

Flaked on HC deletion with one of the EndpointServices still in use i.e. the Endpoint in the guest VPC was still present

{"level":"error","ts":"2022-07-14T03:15:41Z","msg":"Reconciler error","controller":"awsendpointservice","controllerGroup":"hypershift.openshift.io","controllerKind":"AWSEndpointService","aWSEndpointService":{"name":"private-router","namespace":"e2e-clusters-6kw94-example-s8frw"},"namespace":"e2e-clusters-6kw94-example-s8frw","name":"private-router","reconcileID":"6de7aac3-a4f8-44e6-9a62-5be1ab9a3739","error":"failed to delete resource: Service has existing active VPC Endpoint connections!","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/hypershift/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:273\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/hypershift/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:234"}

Copy link
Contributor

@csrwng csrwng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment missed the first time around, otherwise lgtm

@sjenning sjenning force-pushed the hcp-degraded-condition branch from 098243e to c5978b1 Compare July 14, 2022 19:38
@csrwng
Copy link
Contributor

csrwng commented Jul 14, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 14, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 92dbc18 and 8 for PR HEAD c5978b1 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 15, 2022

@sjenning: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit cc0f5af into openshift:main Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants