-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Degraded condition to HCP #1560
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for hypershift-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
76528e7
to
1b5ec4a
Compare
1b5ec4a
to
098243e
Compare
/retest |
/retest-required Flaked on HC deletion with one of the EndpointServices still in use i.e. the Endpoint in the guest VPC was still present
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment missed the first time around, otherwise lgtm
098243e
to
c5978b1
Compare
/lgtm |
@sjenning: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Requires #1554
https://issues.redhat.com/browse/HOSTEDCP-495
Adds a
Degraded
condition on the HCP with ReasonUnavailableReplicas
if any of the CPO managed deployments has astatus.unavailableReplicas
> 0.Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)
format, where issue_number might be a GitHub issue, or a Jira story:Fixes #
Checklist