STOR-2136: Enable volume groupsnapshots APIs v1beta1 version #219
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@gnufied: This pull request references STOR-2136 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gnufied The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@gnufied: This pull request references STOR-2136 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@gnufied you need to update the |
|
and |
gnufied
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
gnufied
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Also change the flag for featuregates
gnufied
force-pushed
the
enable-volume-group-apis
branch
from
87e1508 to
3d5a735
Compare
|
@gnufied: This pull request references STOR-2136 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
go.mod
Outdated
| @@ -124,3 +124,5 @@ replace cloud.google.com/go => cloud.google.com/go v0.104.0 | |||
|
|
|||
| // need this replace to keep upstream on go version 1.22 for bumping to 4.18, delete this in bump to 4.19 | |||
| replace sigs.k8s.io/json => sigs.k8s.io/json v0.0.0-20221116044647-bc3834ca7abd | |||
|
|
|||
| replace github.com/openshift/api => github.com/gnufied/api v0.0.0-20241120011244-2372cad37b95 | |||
There was a problem hiding this comment.
Can you please remove openshift/api bump from this PR? We still want to have group snapshots under TechPreviewNoUpgrade until it's proven stable.
There was a problem hiding this comment.
@jsafrane - what does "proven stable" mean for you? The goal is to have multi-vol snapshots GA in 4.18
There was a problem hiding this comment.
It means we have an e2e test that says, this is working fine in 4.19. We are not there yet in 4.19. We are still aiming for GA in 4.18, but first we need to prove this that this works in 4.19.
|
CI complains:
Please add those exceptions to openshift/origin (?) |
gnufied
force-pushed
the
enable-volume-group-apis
branch
from
addbffc to
49b0de1
Compare
gnufied
changed the title
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest |
| for _, result := range mgmtResouceRemovalResult { | ||
| if result.Error != nil { | ||
| allErrors = append(allErrors, result.Error) | ||
| } | ||
| } | ||
|
|
||
| if len(allErrors) > 0 { | ||
| return utilerrors.NewAggregate(allErrors) | ||
| } |
There was a problem hiding this comment.
NewAggregate already filters nil and empty slices. In theory, this could be enough:
guestResourceRemovalErr := resourceapply.DeleteAll()
mgmtResouceRemovalErr := resourceapply.DeleteAll()
if err := utilerrors.NewAggregate(append(guestResourceRemovalErr,mgmtResouceRemovalErr... ); err != nil {
return err
}
There was a problem hiding this comment.
wait, I forgot. we will have to still extract errors from these objects in a loop. Result of .DeleteAll call is not of error type.
|
/retest |
|
@gnufied: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
QE verified the volumesnapshot/volumesgroupnapshot feature with |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
@gnufied: This pull request references STOR-2136 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-hypershift-conformance |
openshift-merge-bot
bot
merged commit 9dceffb
into
openshift:master
|
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-csi-snapshot-controller-operator |
This is meant to be used with openshift/csi-external-snapshotter#166 which relies on using featuregate for enabling group snapshots.