MGMT-8357: change 'local' deployment method to 'minikube' #4642
+8
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we're gonna (temporarily) have two deployment methods that have different network configuration, we should rename 'local' to 'minikube'. Then assisted-test-infra can pass its value of ``DEPLOY_TARGET`` to what assisted-service calls ``TARGET`` (seems ``DEPLOY_TARGET`` in assisted-service is already used in some other constellation).
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
size/S
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: osherdp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/lgtm |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4642 +/- ##
==========================================
- Coverage 67.03% 66.96% -0.07%
==========================================
Files 200 200
Lines 28194 28241 +47
==========================================
+ Hits 18899 18912 +13
- Misses 7594 7615 +21
- Partials 1701 1714 +13
|
|
@osherdp: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
danielerez
pushed a commit
to danielerez/assisted-service
that referenced
this pull request
Oct 15, 2023
…4642) Since we're gonna (temporarily) have two deployment methods that have different network configuration, we should rename 'local' to 'minikube'. Then assisted-test-infra can pass its value of ``DEPLOY_TARGET`` to what assisted-service calls ``TARGET`` (seems ``DEPLOY_TARGET`` in assisted-service is already used in some other constellation).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're gonna (temporarily) have two deployment methods that have different network configuration, we should rename 'local' to 'minikube'. Then assisted-test-infra can pass its value of
DEPLOY_TARGETto what assisted-service callsTARGET(seemsDEPLOY_TARGETin assisted-service is already used in some other constellation).List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs, README, etc)Reviewers Checklist