Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-11124: remove usage of IMAGE_SERVICE_SCHEME/HOST #4157

Merged
merged 1 commit into from
Jul 20, 2022
Merged

MGMT-11124: remove usage of IMAGE_SERVICE_SCHEME/HOST #4157

merged 1 commit into from
Jul 20, 2022

Conversation

danielerez
Copy link
Contributor

@danielerez danielerez commented Jul 19, 2022 •
edited
Loading

Following to openshift/assisted-image-service#88 and openshift/assisted-image-service#89, IMAGE_SERVICE_SCHEME and IMAGE_SERVICE_HOST vars are now deprecated. Instead, all deployments should now specify only IMAGE_SERVICE_BASE_URL.

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Assignees

/cc @carbonin
/cc @filanov

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • Reviewers have been listed
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

@danielerez
MGMT-11124: remove usage of IMAGE_SERVICE_SCHEME/HOST
349cef2 
Following to openshift/assisted-image-service#88,
IMAGE_SERVICE_SCHEME and IMAGE_SERVICE_HOST vars are now deprecated.
Instead, all deployments should now specify only  IMAGE_SERVICE_BASE_URL.
@danielerez
Copy link
Contributor Author

danielerez commented Jul 19, 2022 •
edited
Loading

/hold
pending on openshift/assisted-image-service#89

@openshift-ci openshift-ci bot requested review from carbonin and filanov July 19, 2022 13:20
@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 19, 2022
@codecov
Copy link

codecov bot commented Jul 19, 2022 •
edited
Loading

Codecov Report

Merging #4157 (349cef2) into master (cbf4a2d) will increase coverage by 0.65%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4157      +/-   ##
==========================================
+ Coverage   65.24%   65.89%   +0.65%     
==========================================
  Files         186      186              
  Lines       26618    27364     +746     
==========================================
+ Hits        17367    18032     +665     
- Misses       7650     7692      +42     
- Partials     1601     1640      +39
Impacted Files Coverage Δ
...oller/controllers/agentserviceconfig_controller.go 83.58% <80.00%> (+0.14%) ⬆️
...rnal/controller/controllers/infraenv_controller.go 60.75% <0.00%> (+0.27%) ⬆️
internal/cluster/validations/validations.go 44.56% <0.00%> (+0.74%) ⬆️
internal/bminventory/inventory.go 70.63% <0.00%> (+0.89%) ⬆️
...nal/controller/controllers/bmh_agent_controller.go 69.65% <0.00%> (+3.02%) ⬆️
...nternal/controller/controllers/agent_controller.go 85.76% <0.00%> (+6.40%) ⬆️

@danielerez
Copy link
Contributor Author

/retest

danielerez added a commit to danielerez/assisted-image-service that referenced this pull request Jul 20, 2022
@danielerez
MGMT-11124: remove deprecated IMAGE_SERVICE_SCHEME/HOST
44644cc 
Following to openshift/assisted-service#4157:
* Remove support for deprecated vars:
  IMAGE_SERVICE_SCHEME and IMAGE_SERVICE_HOST.
* buildRootfsURL func is now simplified to support only
  a specified baseURL.
@danielerez danielerez mentioned this pull request Jul 20, 2022
Merged
5 tasks
@danielerez
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jul 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carbonin, danielerez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [carbonin,danielerez]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Jul 20, 2022

@danielerez: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 4ba9c50 into openshift:master Jul 20, 2022
openshift-merge-robot pushed a commit to openshift/assisted-image-service that referenced this pull request Jul 20, 2022
@danielerez
MGMT-11124: remove deprecated IMAGE_SERVICE_SCHEME/HOST (#90)
46c484a 
Following to openshift/assisted-service#4157:
* Remove support for deprecated vars:
  IMAGE_SERVICE_SCHEME and IMAGE_SERVICE_HOST.
* buildRootfsURL func is now simplified to support only
  a specified baseURL.
flaper87 pushed a commit to flaper87/assisted-service that referenced this pull request Sep 21, 2022
@danielerez
MGMT-11124: remove usage of IMAGE_SERVICE_SCHEME/HOST (openshift#4157)
55a5ee1 
Following to openshift/assisted-image-service#88,
IMAGE_SERVICE_SCHEME and IMAGE_SERVICE_HOST vars are now deprecated.
Instead, all deployments should now specify only  IMAGE_SERVICE_BASE_URL.
danielerez added a commit to danielerez/assisted-service that referenced this pull request Oct 15, 2023
@danielerez
MGMT-11124: remove usage of IMAGE_SERVICE_SCHEME/HOST (openshift#4157)
6f03e09 
Following to openshift/assisted-image-service#88,
IMAGE_SERVICE_SCHEME and IMAGE_SERVICE_HOST vars are now deprecated.
Instead, all deployments should now specify only  IMAGE_SERVICE_BASE_URL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbonin carbonin carbonin approved these changes

@filanov filanov Awaiting requested review from filanov

Assignees

@carbonin carbonin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielerez @carbonin @openshift-merge-robot