NO-ISSUE - Add the ability to override image-service image when deploying the assisted-image-service #3737
Conversation
openshift-ci
bot
added
size/S
Codecov Report
@@ Coverage Diff @@
## master #3737 +/- ##
=======================================
Coverage 65.70% 65.71%
=======================================
Files 176 176
Lines 24549 24549
=======================================
+ Hits 16130 16132 +2
+ Misses 6856 6855 -1
+ Partials 1563 1562 -1
|
eliorerz
force-pushed
the
NO-ISSUE_-_Add_the_ability_to_override_image-service_image_when_deploying_the_assisted-image-service
branch
from
2a763ce to
de86fdb
Compare
…ying the assisted-image-service
eliorerz
force-pushed
the
NO-ISSUE_-_Add_the_ability_to_override_image-service_image_when_deploying_the_assisted-image-service
branch
from
de86fdb to
56df30a
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eliorerz, osherdp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@eliorerz: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/cherry-pick release-ocm-2.5 |
|
@eliorerz: new pull request created: #3758 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@eliorerz: new pull request created: #3758 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…ying the assisted-image-service (openshift#3737)
eliorerz
deleted the
NO-ISSUE_-_Add_the_ability_to_override_image-service_image_when_deploying_the_assisted-image-service
branch
…ying the assisted-image-service (openshift#3737)
Currently deploy-image-service image is defined statically at assisted-image-service.yam.
This PR add the option to override it using REPLACE_IMAGE_SERVICE_IMAGE key.
The IMAGE_SERVICE env var default is defined on the Makefile
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Assignees
/cc @osherdp