MGMT-10197: Adds ENABLE_ORG_BASED_FEATURE_GATES #3727
Merged
+519
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nmagnezi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Codecov Report
@@ Coverage Diff @@
## master #3727 +/- ##
==========================================
- Coverage 66.30% 66.23% -0.08%
==========================================
Files 178 179 +1
Lines 24835 24872 +37
==========================================
+ Hits 16467 16474 +7
- Misses 6845 6876 +31
+ Partials 1523 1522 -1
|
danielerez
reviewed
Apr 28, 2022
|
/retest-required |
|
Consider moving this helper function into a different package |
|
Both the commit, the PR and the ticket lack description that sheds light on the context, motivation and goals for this change. |
nmagnezi
force-pushed
the
MGMT-9136_org_based_feature_enablement
branch
2 times, most recently
from
0cc6f6e to
79816d2
Compare
Done.
You're right. I marked this PR as |
danielerez
reviewed
May 11, 2022
eliorerz
reviewed
May 12, 2022
nmagnezi
force-pushed
the
MGMT-9136_org_based_feature_enablement
branch
from
79816d2 to
8d7b789
Compare
|
/retest-required |
nmagnezi
force-pushed
the
MGMT-9136_org_based_feature_enablement
branch
from
8d7b789 to
f3f6e5b
Compare
openshift-ci
bot
added
size/XL
|
/test subsystem-aws |
|
@nmagnezi: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
nmagnezi
force-pushed
the
MGMT-9136_org_based_feature_enablement
branch
7 times, most recently
from
8ac262a to
069b0ad
Compare
nmagnezi
force-pushed
the
MGMT-9136_org_based_feature_enablement
branch
from
6937a59 to
3e03bf6
Compare
avishayt
reviewed
May 25, 2022
nmagnezi
force-pushed
the
MGMT-9136_org_based_feature_enablement
branch
3 times, most recently
from
0217167 to
2832515
Compare
|
/retest-required |
nmagnezi
changed the title
nmagnezi
changed the title
|
@nmagnezi: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test subsystem-kubeapi-aws |
|
@nmagnezi: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required |
|
/lgtm |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
Some features might be of interest to partners or early adopters. Other features might not be ready for public consumption: tech-preview or an internal-only functionality. This change adds a method to the authorization middleware for asserting a particular capability against the user's organization-assigned capabilities. This change also includes an implementation related to ARM-based CPU architecture capability of (via the above-mentioned method) with the following APIs: - V2RegisterCluster - RegisterInfraEnv Note that V2ListSupportedOpenshiftVersions is also relevant here and will be included in a follow-up change. Find additional information in the feature enablement enhancement doc: openshift#3744
|
/lgtm |
nmagnezi
force-pushed
the
MGMT-9136_org_based_feature_enablement
branch
from
2832515 to
96e4091
Compare
|
/lgtm |
16 tasks
flaper87
pushed a commit
to flaper87/assisted-service
that referenced
this pull request
Sep 21, 2022
Some features might be of interest to partners or early adopters. Other features might not be ready for public consumption: tech-preview or an internal-only functionality. This change adds a method to the authorization middleware for asserting a particular capability against the user's organization-assigned capabilities. This change also includes an implementation related to ARM-based CPU architecture capability of (via the above-mentioned method) with the following APIs: - V2RegisterCluster - RegisterInfraEnv Note that V2ListSupportedOpenshiftVersions is also relevant here and will be included in a follow-up change. Find additional information in the feature enablement enhancement doc: openshift#3744
danielerez
pushed a commit
to danielerez/assisted-service
that referenced
this pull request
Oct 15, 2023
Some features might be of interest to partners or early adopters. Other features might not be ready for public consumption: tech-preview or an internal-only functionality. This change adds a method to the authorization middleware for asserting a particular capability against the user's organization-assigned capabilities. This change also includes an implementation related to ARM-based CPU architecture capability of (via the above-mentioned method) with the following APIs: - V2RegisterCluster - RegisterInfraEnv Note that V2ListSupportedOpenshiftVersions is also relevant here and will be included in a follow-up change. Find additional information in the feature enablement enhancement doc: openshift#3744
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some features might be of interest to partners or early adopters.
Other features might not be ready for public consumption: tech-preview or an internal-only functionality.
This change adds a method to the authorization middleware for asserting a particular capability against the user's organization-assigned capabilities.
This change also includes an implementation related to ARM-based CPU architecture capability of (via the above-mentioned method) with the following APIs:
Note that V2ListSupportedOpenshiftVersions is also relevant here and will be included in a follow-up change.
Find additional information in the feature enablement enhancement doc: #3744
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Assignees
/cc @
/cc @
Checklist
docs, README, etc)Reviewers Checklist