Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-ISSUE: added arm64 images for ocp 4.10 #3566

Merged
merged 1 commit into from
Mar 31, 2022
Merged

NO-ISSUE: added arm64 images for ocp 4.10 #3566

merged 1 commit into from
Mar 31, 2022

Conversation

danielerez
Copy link
Contributor

Added 4.10 arm64 images to default_os_images and default_release_images.

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Assignees

/cc @osherdp
/cc @gamli75

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • Reviewers have been listed
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

@openshift-ci openshift-ci bot requested review from gamli75 and osherdp March 27, 2022 09:45
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 27, 2022
osherdp
osherdp approved these changes Mar 27, 2022
View reviewed changes
Copy link
Contributor

@osherdp osherdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hope PV size is enough for it in integration
If not, we can always remove 4.9 ARM image (or increase the size)

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2022
@codecov
Copy link

codecov bot commented Mar 27, 2022 •
edited
Loading

Codecov Report

Merging #3566 (3d85bb4) into master (dc59fc0) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3566      +/-   ##
==========================================
+ Coverage   66.57%   66.64%   +0.07%     
==========================================
  Files         172      175       +3     
  Lines       24488    24891     +403     
==========================================
+ Hits        16303    16589     +286     
- Misses       6593     6688      +95     
- Partials     1592     1614      +22
Impacted Files Coverage Δ
...al/controller/controllers/agentlabel_controller.go 57.14% <0.00%> (ø)
...all/v1beta1/agent_classification_admission_hook.go 79.33% <0.00%> (ø)
...ller/controllers/agentclassification_controller.go 57.89% <0.00%> (ø)
...nternal/controller/controllers/agent_controller.go 80.34% <0.00%> (+1.15%) ⬆️

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@romfreiman
Copy link
Contributor

Lets remove 4.9. Why do we need it?

@osherdp @gamli75 why are we running 4.6 job here?

@gamli75
Copy link
Contributor

gamli75 commented Mar 27, 2022

Lets remove 4.9. Why do we need it?

@osherdp @gamli75 why are we running 4.6 job here?

@romfreiman we have task & open PR for it, see: https://issues.redhat.com/browse/MGMT-9743

@osherdp
Copy link
Contributor

osherdp commented Mar 27, 2022

Shouldn't bother us anymore (when updating data/ dir): openshift/release/pull/27322

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@osherdp
Copy link
Contributor

osherdp commented Mar 27, 2022

/hold
seems like verify-generated-code fails consistently
(and it might be a good idea to remove 4.9 ARM image on the way)

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 27, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2022
@osherdp
Copy link
Contributor

osherdp commented Mar 28, 2022

/override ci/prow/e2e-ai-operator-ztp-ipv4v6-3masters-ocp-49
/override ci/prow/e2e-ai-operator-ztp-ipv4v6-sno-ocp-49
(currently broken)
/unhold
(anything else looks okay)

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 28, 2022

@osherdp: Overrode contexts on behalf of osherdp: ci/prow/e2e-ai-operator-ztp-ipv4v6-3masters-ocp-49, ci/prow/e2e-ai-operator-ztp-ipv4v6-sno-ocp-49

In response to this:

/override ci/prow/e2e-ai-operator-ztp-ipv4v6-3masters-ocp-49
/override ci/prow/e2e-ai-operator-ztp-ipv4v6-sno-ocp-49
(currently broken)
/unhold
(anything else looks okay)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@osherdp
Copy link
Contributor

osherdp commented Mar 29, 2022

/hold
subsystem job fails consistently, and the tests failing symptom only appears for this PR
@danielerez can you take a look?

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 29, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2022
@danielerez
Copy link
Contributor Author

Details

updated tests, let's see now

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2022
@danielerez
NO-ISSUE: added arm64 images for ocp 4.10
3d85bb4 
Added 4.10 arm64 images to default_os_images and default_release_images.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielerez, osherdp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@danielerez
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 29, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link

openshift-ci bot commented Mar 30, 2022

@danielerez: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ai-operator-ztp-ipv4v6-3masters-ocp-49 3d85bb4 link false /test e2e-ai-operator-ztp-ipv4v6-3masters-ocp-49
ci/prow/e2e-metal-assisted-kube-api-net-suite 3d85bb4 link true /test e2e-metal-assisted-kube-api-net-suite

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@danielerez
Copy link
Contributor Author

/hold
pending #3594

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 30, 2022
@danielerez
Copy link
Contributor Author

/unhold
/retest

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 30, 2022
@openshift-merge-robot openshift-merge-robot merged commit 597bd82 into openshift:master Mar 31, 2022
flaper87 pushed a commit to flaper87/assisted-service that referenced this pull request Sep 21, 2022
@danielerez
NO-ISSUE: added arm64 images for ocp 4.10 (openshift#3566)
112f740 
Added 4.10 arm64 images to default_os_images and default_release_images.
danielerez added a commit to danielerez/assisted-service that referenced this pull request Oct 15, 2023
@danielerez
NO-ISSUE: added arm64 images for ocp 4.10 (openshift#3566)
f7bb009 
Added 4.10 arm64 images to default_os_images and default_release_images.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osherdp osherdp osherdp approved these changes

@gamli75 gamli75 Awaiting requested review from gamli75

Assignees

@osherdp osherdp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@danielerez @openshift-bot @romfreiman @gamli75 @osherdp @openshift-merge-robot