Remove broken link from DEVELOPER_GUIDE.md #2582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saadat Nursultan <nursultan.saadat@gmail.com>
Signed-off-by: Saadat Nursultan <nursultan.saadat@gmail.com>
nurSaadat
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied,
RyanL1997 and
stephen-crawford
as code owners
cwperks
previously approved these changes
Mar 23, 2023
|
Thank you for the contribution @nurSaadat! The change looks good to me. It could be worth mentioning that the output of |
stephen-crawford
previously approved these changes
Mar 23, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #2582 +/- ##
============================================
+ Coverage 61.22% 61.26% +0.03%
- Complexity 3327 3331 +4
============================================
Files 260 260
Lines 18509 18509
Branches 3269 3269
============================================
+ Hits 11332 11339 +7
+ Misses 5579 5575 -4
+ Partials 1598 1595 -3 see 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
peternied
requested changes
Mar 23, 2023
nurSaadat
dismissed stale reviews from stephen-crawford and cwperks
via
0d7fedb
Signed-off-by: Saadat Nursultan <nursultan.saadat@gmail.com>
Signed-off-by: Saadat Nursultan <nursultan.saadat@gmail.com>
nurSaadat
force-pushed
the
nurSaadat-patch-1
branch
from
3e208b2 to
4844934
Compare
stephen-crawford
approved these changes
Mar 24, 2023
MaciejMierzwa
pushed a commit
to MaciejMierzwa/security
that referenced
this pull request
Apr 20, 2023
* Update DEVELOPER_GUIDE.md Signed-off-by: Saadat Nursultan <nursultan.saadat@gmail.com> * Update DEVELOPER_GUIDE.md Signed-off-by: Saadat Nursultan <nursultan.saadat@gmail.com> * Update DEVELOPER_GUIDE.md Signed-off-by: Saadat Nursultan <nursultan.saadat@gmail.com> * Update DEVELOPER_GUIDE.md Signed-off-by: Saadat Nursultan <nursultan.saadat@gmail.com> --------- Signed-off-by: Saadat Nursultan <nursultan.saadat@gmail.com> Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
MaciejMierzwa
pushed a commit
to MaciejMierzwa/security
that referenced
this pull request
Apr 27, 2023
* Update DEVELOPER_GUIDE.md Signed-off-by: Saadat Nursultan <nursultan.saadat@gmail.com> * Update DEVELOPER_GUIDE.md Signed-off-by: Saadat Nursultan <nursultan.saadat@gmail.com> * Update DEVELOPER_GUIDE.md Signed-off-by: Saadat Nursultan <nursultan.saadat@gmail.com> * Update DEVELOPER_GUIDE.md Signed-off-by: Saadat Nursultan <nursultan.saadat@gmail.com> --------- Signed-off-by: Saadat Nursultan <nursultan.saadat@gmail.com> Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Documentation
These changes keep the documentation up-to-date according to the changes which were introduced in earlier contributions.
Before the changes, when clicking on the "here" link in the "Native platforms" section of DEVELOPER_GUIDE.md the user was redirected to a page with 404 error and a message
The 'opensearch-project/security' repository doesn't contain the 'plugin-descriptor.properties' path in 'main'.After the changes, the "Worth noting" paragraph was put after building code snippet, so that the user will be able to access the
plugin-descriptor.propertiesfile, which is created programmatically after #1623Issues Resolved
Testing
Tested manually by reviewing the edited .md document in the forked repo.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.