Extract the data-prepper-plugin-framework from data-prepper-core #4260
Conversation
…module Signed-off-by: Taylor Gray <tylgry@amazon.com>
graytaylor0
requested review from
chenqi0805,
engechas,
dinujoh,
kkondaka,
asifsmohammed,
dlvenable and
oeyh
as code owners
…new module Signed-off-by: Taylor Gray <tylgry@amazon.com>
graytaylor0
force-pushed
the
PluginFramework
branch
from
deec5c6 to
0102a91
Compare
| @@ -0,0 +1,7 @@ | |||
| package org.opensearch.dataprepper.plugin; | |||
There was a problem hiding this comment.
We should probably change this package to be something else. But, maybe in another PR.
| @@ -3,7 +3,7 @@ | |||
| * SPDX-License-Identifier: Apache-2.0 | |||
| */ | |||
|
|
|||
| package org.opensearch.dataprepper.parser; | |||
| package org.opensearch.dataprepper.pipeline.parser; | |||
There was a problem hiding this comment.
We should look to see if we can make this package protected. Perhaps in another PR. It might involve moving a few other classes to reside in the same package.
| @@ -3,7 +3,7 @@ | |||
| * SPDX-License-Identifier: Apache-2.0 | |||
| */ | |||
|
|
|||
| package org.opensearch.dataprepper.parser; | |||
| package org.opensearch.dataprepper.pipeline.parser; | |||
There was a problem hiding this comment.
We should look to see if we can make this package protected. Perhaps in another PR. It might involve moving a few other classes to reside in the same package.
| @@ -3,7 +3,7 @@ | |||
| * SPDX-License-Identifier: Apache-2.0 | |||
| */ | |||
|
|
|||
| package org.opensearch.dataprepper.plugin; | |||
| package org.opensearch.dataprepper.plugins; | |||
There was a problem hiding this comment.
I think this should remain in the old package. It uses package protected classes.
Also, we want to be sure that it does not interfere with loading the test plugins, which reside in .plugins.
The names are a little ambiguous. But, .plugin is the plugin framework and .plugins is the package for loading classes.
| @@ -25,7 +25,7 @@ | |||
| * <p><i>publicContext</i> is the root {@link ApplicationContext}</p> | |||
| */ | |||
| @Named | |||
| class PluginBeanFactoryProvider implements Provider<BeanFactory> { | |||
| public class PluginBeanFactoryProvider implements Provider<BeanFactory> { | |||
There was a problem hiding this comment.
Can we keep this package protected?
My initial suspicion is that this was caused by making DefaultPluginFactoryIT reside in .plugins.
Signed-off-by: Taylor Gray <tylgry@amazon.com>
Description
This change creates a high level module of
data-prepper-plugin-frameworkand extracts the plugin framework code from data-prepper-coreIt also
ExtensionConfigurationthatDataPrepperConfigurationnow implementsDataPrepperDurationDeserializerandBytesDeserializertodata-prepper-pipeline-parserIssues Resolved
Related to #2573
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.