Always use constant_score query for match_only_text #16964
Merged
+52
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, when we create a term query over a `match_only_text` field, it may still try to compute scores, which prevents early termination. We should *always* use a constant score query when querying `match_only_text`, since we don't have the statistics required to compute scores. Signed-off-by: Michael Froh <froh@amazon.com>
msfroh
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
@rishabhmaurya -- you may be interested in this |
msfroh
added
v2.19.0
Signed-off-by: Michael Froh <froh@amazon.com>
|
❌ Gradle check result for 399ddaf: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
reta
approved these changes
Jan 6, 2025
Signed-off-by: Michael Froh <froh@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16964 +/- ##
============================================
- Coverage 72.32% 72.21% -0.12%
+ Complexity 65310 65246 -64
============================================
Files 5299 5299
Lines 303534 303536 +2
Branches 43941 43941
============================================
- Hits 219527 219187 -340
- Misses 66021 66391 +370
+ Partials 17986 17958 -28 ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16964 +/- ##
============================================
- Coverage 72.32% 72.21% -0.12%
+ Complexity 65310 65246 -64
============================================
Files 5299 5299
Lines 303534 303536 +2
Branches 43941 43941
============================================
- Hits 219527 219187 -340
- Misses 66021 66391 +370
+ Partials 17986 17958 -28 ☔ View full report in Codecov by Sentry. |
reta
approved these changes
Jan 7, 2025
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-16964-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0b365998ed6e4f537dbdf7983a077bc53e785bb9
# Push it to GitHub
git push --set-upstream origin backport/backport-16964-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.xThen, create a pull request where the |
msfroh
added a commit
to msfroh/OpenSearch
that referenced
this pull request
Jan 7, 2025
…ct#16964) In some cases, when we create a term query over a `match_only_text` field, it may still try to compute scores, which prevents early termination. We should *always* use a constant score query when querying `match_only_text`, since we don't have the statistics required to compute scores. --------- Signed-off-by: Michael Froh <froh@amazon.com> (cherry picked from commit 0b36599)
3 tasks
|
Manual backport PR: #16969 |
msfroh
added a commit
that referenced
this pull request
Jan 8, 2025
In some cases, when we create a term query over a `match_only_text` field, it may still try to compute scores, which prevents early termination. We should *always* use a constant score query when querying `match_only_text`, since we don't have the statistics required to compute scores. --------- Signed-off-by: Michael Froh <froh@amazon.com> (cherry picked from commit 0b36599)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some cases, when we create a term query over a
match_only_textfield, it may still try to compute scores, which prevents early termination. We should always use a constant score query when queryingmatch_only_text, since we don't have the statistics required to compute scores.Related Issues
N/A
We've seen benchmark latency on the Big5
query-string-on-messageoperation, which we can attribute to this.Check List
API changes companion pull request created, if applicable.Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.