Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separating remote download and publication stats #16682

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Separating remote download and publication stats #16682

merged 3 commits into from
Nov 21, 2024

Conversation

himshikha
Copy link
Contributor

@himshikha himshikha commented Nov 19, 2024 •
edited
Loading

Description

This change is aimed at providing granular metrics for remote download and overall remote incoming publication flow separately.

  • Moved remote download failure stat to the RemoteClusterStateService download methods.
  • Added new stat for remote publication failure during download.
          "remote_full_download" : {
            "success_count" : 1,
            "failed_count" : 0,
            "total_time_in_millis" : 4,
            "incoming_publication_failed_count" : 0,
            "checksum_validation_failed_count" : 0
          },
          "remote_diff_download" : {
            "success_count" : 2,
            "failed_count" : 0,
            "total_time_in_millis" : 12,
            "incoming_publication_failed_count" : 0,
            "checksum_validation_failed_count" : 0
          }

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

separating remote download and publication stats
72d5889 
Signed-off-by: Himshikha Gupta <himshikh@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 72d5889: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@soosinha
Copy link
Member

Can you update the description with why this change is needed ?

Bukhtawar
Bukhtawar reviewed Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@Bukhtawar Bukhtawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am assuming this won't break ser/de(BWC) with version upgrades

@himshikha
Copy link
Contributor Author

I am assuming this won't break ser/de(BWC) with version upgrades

Since we are only adding new field, it shouldn't break BWC

Himshikha Gupta added 2 commits November 20, 2024 15:38
add tests
e93786b 
Signed-off-by: Himshikha Gupta <himshikh@amazon.com>
Add changelog
61b8e44 
Signed-off-by: Himshikha Gupta <himshikh@amazon.com>
@himshikha himshikha marked this pull request as ready for review November 20, 2024 10:13
@himshikha himshikha self-assigned this Nov 20, 2024
@himshikha himshikha added the backport 2.x Backport to 2.x branch label Nov 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 61b8e44: SUCCESS

@Bukhtawar Bukhtawar merged commit b1a7743 into opensearch-project:main Nov 21, 2024
61 of 63 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 21, 2024
@github-actions
Separating remote download and publication stats (#16682)
321afe6 
* Separating remote download and publication stats

Signed-off-by: Himshikha Gupta <himshikh@amazon.com>
(cherry picked from commit b1a7743)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Nov 21, 2024
Closed
himshikha added a commit to himshikha/OpenSearch that referenced this pull request Nov 21, 2024
@himshikha
Separating remote download and publication stats (opensearch-project#…
5c791ed 
…16682)

* Separating remote download and publication stats

Signed-off-by: Himshikha Gupta <himshikh@amazon.com>
@himshikha himshikha mentioned this pull request Nov 21, 2024
Merged
3 tasks
Bukhtawar pushed a commit that referenced this pull request Nov 25, 2024
@himshikha
[Backport 2.x] Backport remote publication stats (#16699)
1b2c543 
* Separating remote download and publication stats (#16682)

Signed-off-by: Himshikha Gupta <himshikh@amazon.com>
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Jan 21, 2025
@himshikha @akolarkunnu
Separating remote download and publication stats (opensearch-project#…
185b64e 
…16682)

* Separating remote download and publication stats

Signed-off-by: Himshikha Gupta <himshikh@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bukhtawar Bukhtawar Bukhtawar approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees

@himshikha himshikha

Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@himshikha @soosinha @Bukhtawar