Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update or-map-widget.ts #931

Merged
merged 5 commits into from
Feb 2, 2023
Merged

Update or-map-widget.ts #931

merged 5 commits into from
Feb 2, 2023

Conversation

NinaBianca
Copy link
Contributor

Insights: Map improvements #928

  • Add default zoom and center values
  • Expand all widget settings panels

Insights: Map improvements #928
* Add default zoom and center values
* Expand all widget settings panels
@NinaBianca NinaBianca requested review from richturner and MartinaeyNL and removed request for richturner January 27, 2023 08:36
* Coordinates turned the wrong way around
* Translated showLabels + showUnits
* Renamed settingspanels
* Uncollapsed thresholds panel
* Bugfix default zoom and center settings
Copy link
Contributor

@MartinaeyNL MartinaeyNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor code cleanup comments that only take a minute to change. Other changes and the API call are ok 👍
No second review necessary; will merge when changed

@NinaBianca NinaBianca merged commit 59c6dc2 into master Feb 2, 2023
@NinaBianca NinaBianca deleted the enhancement/insights-map branch February 2, 2023 11:57
DonWillems pushed a commit that referenced this pull request Feb 5, 2023
* Update or-map-widget.ts

Insights: Map improvements #928
* Add default zoom and center values
* Expand all widget settings panels

* Issue #928 followup

* Coordinates turned the wrong way around
* Translated showLabels + showUnits
* Renamed settingspanels
* Uncollapsed thresholds panel
* Bugfix default zoom and center settings

* Requested updates

* Update or-map-widget.ts

* include realm in API call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants