Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several bugfixes for appearance page. #1062

Merged
merged 18 commits into from
Jun 13, 2023
Merged

Several bugfixes for appearance page. #1062

merged 18 commits into from
Jun 13, 2023

Conversation

MartinaeyNL
Copy link
Contributor

@MartinaeyNL MartinaeyNL commented May 30, 2023 •
edited
Loading

Did a rewrite on some functions on the appearance page after several bugs got discovered.
I improved the overall code to improve consistency, and added more error handling to prevent edge cases.

Full changelog:

  • Major rework of frontend appearance page code, providing consistency. Such as removing unnecessairy UI updates,
    removing {} object creations, preventing too many HTTP requests, and moving some logic to parent components.
  • Made generic or-conf-panel, getting rid of duplicate code for or-conf-map and or-conf-realm.
  • Save button on appearance page is now only enabled when changes have been made.
  • Moved JSON editor to only the "realm config"-section of the appearance page.
  • Minor styling/translation fixes.

@MartinaeyNL MartinaeyNL mentioned this pull request May 30, 2023
Closed
2 tasks
@MartinaeyNL MartinaeyNL linked an issue Jun 6, 2023 that may be closed by this pull request
Appearance: don't allow deleting configs for 'default' #1064
Closed
@MartinaeyNL MartinaeyNL mentioned this pull request Jun 9, 2023
Closed
@MartinaeyNL MartinaeyNL linked an issue Jun 9, 2023 that may be closed by this pull request
Appearance: icons not correctly saved #1063
Closed
@MartinaeyNL MartinaeyNL marked this pull request as ready for review June 12, 2023 15:50
@MartinaeyNL
Copy link
Contributor Author

Ready for review 👍

@MartinaeyNL MartinaeyNL requested a review from richturner June 12, 2023 15:55
@richturner richturner merged commit 3de4f78 into master Jun 13, 2023
@richturner richturner deleted the bugfix/configuration-saving branch June 13, 2023 20:32
richturner pushed a commit that referenced this pull request Jun 14, 2023
@MartinaeyNL @richturner
UI update: Several bugfixes for appearance page (#1062)
37f54f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richturner richturner richturner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Appearance: don't allow deleting configs for 'default' Appearance: icons not correctly saved
2 participants
@MartinaeyNL @richturner