Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User query enhancements and JSON rule updates and fixes #1032

Merged
merged 6 commits into from
Apr 13, 2023
Merged

User query enhancements and JSON rule updates and fixes #1032

merged 6 commits into from
Apr 13, 2023

Conversation

richturner
Copy link
Member

Fixes #1027, Closes #961, Fixes #885

@richturner richturner requested a review from MartinaeyNL April 13, 2023 14:07
@richturner
Copy link
Member Author

  • Enhancements to UserQuery to allow user attributes and realm roles to be queried
  • JSON Rules update to add extra options to Notification action with user target (each realm role can be used to filter matched linked users)
  • JSON Rules fix for multiple OR conditions where only last would trigger the rule
  • Fixed gradle issue when repo used as submodule and .git dir is missing
  • Updated @mdi/font dependency

MartinaeyNL
MartinaeyNL approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@MartinaeyNL MartinaeyNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Only saw a single comment I didn't understand; see feedback.

manager/src/main/java/org/openremote/manager/security/UserResourceImpl.java Show resolved Hide resolved
@richturner richturner merged commit cb47b07 into master Apr 13, 2023
@richturner richturner deleted the user_query_enhancement branch April 13, 2023 15:50
@MartinaeyNL MartinaeyNL mentioned this pull request Apr 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinaeyNL MartinaeyNL MartinaeyNL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@richturner @MartinaeyNL