Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (intuitive) support for pinning the output of a pipeline stage #612

Merged

Conversation

richard-sim
Copy link
Contributor

Description

Add (intuitive) support for pinning the output of a pipeline stage while other stages are edited.

Justification

Suggested in #569.

Instructions for Use

You can click the pin button on the right side of the results toolbar to pin the output of a pipeline stage so that it continues to be displayed while you edit other stages in the pipeline, letting you see how your changes impact things down the line.

Implementation Details

  1. How did you test the change? Be descriptive. Untested code will not be accepted.
    Tested editing the pipeline for the Fiducial Camera when running with -DoverrideUserConfig=true. Tested navigating by both the pipeline panel and the navigation buttons, with and without stages pinned.
  2. Did you follow the coding style?
    I believe so.
  3. If you made changes in the org.openpnp.spi or org.openpnp.model packages you will need to add additional justification for these changes. Changes to these packages require extensive review and testing.
    No changes.
  4. Be sure to run mvn test before submitting the Pull Request. If the tests do not pass the Pull Request will not be accepted.
    Done.

@vonnieda vonnieda merged commit 4894975 into openpnp:develop Jul 30, 2017
@vonnieda
Copy link
Member

Great addition, and nice, clean PR. Thank you for making my job easy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants