Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Short URL link related Issues/Observations #4757

Closed
2 of 3 tasks
neha00290 opened this issue Oct 11, 2024 · 0 comments · Fixed by #4773
Closed
2 of 3 tasks

Short URL link related Issues/Observations #4757

neha00290 opened this issue Oct 11, 2024 · 0 comments · Fixed by #4773
Assignees
@bjp232004 @Loaki07
Labels
☢️ Bug Something isn't working

Comments

@neha00290
Copy link
Contributor

neha00290 commented Oct 11, 2024 •
edited
Loading

Which OpenObserve functionalities are the source of the bug?

log search

Is this a regression?

Yes

Description

  • Sharing a link for a log search and opening the link in incognito, signup with SSO, the user is not redirected to the URL that is shared.
  • on entering invalid URL, logging in with SSO , i am getting error Short URL not found
  • On entering timezone in alerts and click on the url and when user clicks on it in SSO in incognito, the timezone added in alert is not displayed

Please provide a link to a minimal reproduction of the bug

No response

Please provide the exception or error you saw

No response

Please provide the version you discovered this bug in (check about page for version information)

Version
Commit Hash
Build Date
v0.12.1
2134b32e181c27ac91650288a6ee3e35132295d3
2024-10-11T05:55:33Z

Anything else?

No response
@neha00290 neha00290 added the ☢️ Bug Something isn't working label Oct 11, 2024
bjp232004 added a commit that referenced this issue Oct 11, 2024
@bjp232004
fix: issue #4757 short url implementation approach change
d037cae
@Loaki07 Loaki07 mentioned this issue Oct 11, 2024
Merged
hengfeiyang pushed a commit that referenced this issue Oct 11, 2024
@Loaki07
feat: redirect response builder with query params & handle Result f…
0205ac6 
…or AuthExtractor in oo_validator (#4758)

Fixes: #4757
bjp232004 added a commit that referenced this issue Oct 11, 2024
@bjp232004
fix: issue #4757 short url implementation approach change
9ed1fff
@Loaki07 Loaki07 mentioned this issue Oct 11, 2024
Merged
hengfeiyang pushed a commit that referenced this issue Oct 11, 2024
@Loaki07
fix: invalid short url redirect (#4763)
eb7536a 
Fixes: #4757, point 2
@Loaki07 Loaki07 mentioned this issue Oct 11, 2024
Merged
hengfeiyang pushed a commit that referenced this issue Oct 11, 2024
@Loaki07
fix: shorten api error handling (#4764)
35f5693 
Fixes: #4757
bjp232004 added a commit that referenced this issue Oct 14, 2024
@bjp232004
fix: issue #4757 short url implementation approach change
46eb645
bjp232004 added a commit that referenced this issue Oct 14, 2024
@bjp232004
fix: issue #4757 short url implementation approach change (#4760)
ad6845c 
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Improved user redirection handling based on the presence of a
`redirect_url` or `short_url` query parameter.
	- Enhanced support for short URLs redirecting to backend API endpoints.
- **Bug Fixes**
- Updated default redirect URI to ensure consistent behavior with
trailing slashes.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Subhra264 pushed a commit that referenced this issue Oct 14, 2024
@Loaki07 @Subhra264
feat: redirect response builder with query params & handle Result f…
f289e64 
…or AuthExtractor in oo_validator (#4758)

Fixes: #4757
Subhra264 pushed a commit that referenced this issue Oct 14, 2024
@Loaki07 @Subhra264
fix: invalid short url redirect (#4763)
9148fcf 
Fixes: #4757, point 2
Subhra264 pushed a commit that referenced this issue Oct 14, 2024
@Loaki07 @Subhra264
fix: shorten api error handling (#4764)
d9b0f9a 
Fixes: #4757
@Subhra264 Subhra264 mentioned this issue Oct 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjp232004 bjp232004

@Loaki07 Loaki07

Labels
☢️ Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Short url fixes openobserve/openobserve
3 participants
@bjp232004 @Loaki07 @neha00290