Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: let dledger complete responseFutures after applying entries to statemachine #132

Merged
merged 6 commits into from
Apr 26, 2022
Merged

Feature: let dledger complete responseFutures after applying entries to statemachine #132

merged 6 commits into from
Apr 26, 2022

Conversation

hzh0425
Copy link
Contributor

@hzh0425 hzh0425 commented Apr 25, 2022

let dledger complete responseFutures after applying entries to statemachine

@hzh0425
Copy link
Contributor Author

hzh0425 commented Apr 25, 2022

@RongtongJin please take a look

RongtongJin
RongtongJin reviewed Apr 26, 2022
View reviewed changes
Copy link
Contributor

@RongtongJin RongtongJin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to print applied index watermarks regularly like committed index

src/main/java/io/openmessaging/storage/dledger/DLedgerEntryPusher.java Outdated Show resolved Hide resolved
@RongtongJin
Copy link
Contributor

LGTM～

@RongtongJin RongtongJin merged commit 6775159 into openmessaging:statemachine Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RongtongJin RongtongJin RongtongJin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hzh0425 @RongtongJin