Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for tribute-contracts v2.3.5 #542

Merged
merged 15 commits into from
Feb 8, 2022
Merged

Updates for tribute-contracts v2.3.5 #542

merged 15 commits into from
Feb 8, 2022

Conversation

jdville03
Copy link
Member

🥳 Adds

  • allow connected delegate to access member's profile page
  • allow connected delegate to update member's delegate key
  • add "member address is delegated..." reason to useMemberActionDisabled hook (if member has delegated member rights, then the member is no longer considered isActiveMember and cannot take any member actions)

✨ Updates

  • update tribute-contracts dependency to 2.3.5
  • update isActiveMember check handling after breaking changes with tribute-contracts@2.3.5
  • fix tests to handle breaking changes
  • use checksum formatting to display ETH address in connected member button (for consistent casing)

🐞 Bugs squashed

  • fix fetching delegate keys by member addresses

⛔️ Removes

  • remove unnecessary use of multicall in useCheckApplicant hook

🧹 Chores done

  • fix variable name and comment typos

@jdville03
Copy link
Member Author

jdville03 commented Feb 7, 2022 •
edited
Loading

TODOs before merging this PR:

  • deploy new Rinkeby tribute-contracts v2.3.5
  • deploy subgraph for new Rinkeby smart contracts
  • update deploy-dev GH action to use new REACT_APP_DAO_REGISTRY_CONTRACT_ADDRESS
  • configure tribute DAO in dev coupon-manager to use new daoAddress
  • clear tribute space data in dev snapshot-hub-erc712

@jdville03 jdville03 merged commit 52aa68e into main Feb 8, 2022
@jdville03 jdville03 deleted the tribute-contracts-2.3.5 branch February 8, 2022 19:29
github-actions bot pushed a commit that referenced this pull request Feb 8, 2022
@jdville03
Updates for tribute-contracts v2.3.5 (#542)
43a21f1 
* WIP fix v2.3.4 breaking changes

* use tribute-contracts local package

* revert temporary nav fix

* WIP handle isActiveMember breaking changes

* fix delegation handling

* WIP fix tests

* fix variable names

* add test case for member  who has delegated

* use tribute-contracts 2.3.5

* show checksum address (for consistent casing)

* update isActiveMember check handling and fix tests

* include highlight effect for connected delegate user

* remove unnecessary use of multicall

* add new demo rinkeby DaoRegistry address

* update rinkeby contract addresses 52aa68e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jdville03