Conditionally set tx gasPrice based on EIP-1559 support
#460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
that referenced
this pull request
Aug 18, 2021
* adds `test/web3Responses/fixtures` * adds `isEIP1559Compatible` web3 helper * adds new option `useETHGasPrice` to not run if EIP-1559 support * adds conditional `gasPrice` to tx based on EIP-1559 support 7ee8746
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #458
🥳 Adds
test/web3Responses/fixturesisEIP1559Compatibleweb3 helper✨ Updates
useETHGasPriceto not run if EIP-1559 supportgasPricefrom transactions #457gasPriceis used tx's will use theaverage(fromfast) gas price. Due to Ethereum network changes, they may pay far more than they wanted to.🐞 Bugs squashed