Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing workflowitem columns to exported excel #509

Merged
merged 8 commits into from
Jul 6, 2020

Conversation

Stezido
Copy link
Contributor

@Stezido Stezido commented Jun 29, 2020

Description

In this PR following tasks shall be completed:

Last task should prevent a developer to forget adding a new property to the execl-export project.

Closes #510
Closes #511
Closes #512

Add workflowitemTypes and dueDate to exported excel sheet
@Stezido Stezido added this to the Trubudget 1.12.0 milestone Jun 29, 2020
@Stezido Stezido self-assigned this Jun 29, 2020
@openkfwCI
Copy link

openkfwCI commented Jun 29, 2020

NotesTime
Note for Reviewer: E2E tests on remote server succeededFri, 03 Jul 2020 13:46:55 +0000

Generated by E2E-Test

@openkfwCI
Copy link

openkfwCI commented Jun 29, 2020

Warnings
⚠️ A new TODO was added.

Generated by 🚫 dangerJS against 4876994

@Stezido Stezido force-pushed the add-missing-excel-columns branch 2 times, most recently from 93aab98 to c010cc0 Compare June 30, 2020 13:11
@Stezido Stezido removed this from the Trubudget 1.12.0 milestone Jul 2, 2020
@Stezido Stezido force-pushed the add-missing-excel-columns branch from c010cc0 to 2454203 Compare July 2, 2020 09:43
Stezido added 5 commits July 2, 2020 12:00
If property was added for one of the resources in the api (project/subproject/workflowitem),
the exported excel sheet must be adapted so it also exports the new property
Due to the combination of a log limit of 4MB and a tons of npm audit output
the audit job would fail.
@Stezido Stezido removed their assignment Jul 3, 2020
@Stezido Stezido requested a review from daniel-arnauer July 3, 2020 11:33
Copy link
Contributor

@daniel-arnauer daniel-arnauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@Stezido Stezido merged commit 0c00090 into master Jul 6, 2020
@Stezido Stezido deleted the add-missing-excel-columns branch July 15, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants