Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow enabling/disabling of users #494

Merged
merged 7 commits into from
Aug 7, 2020
Merged

Allow enabling/disabling of users #494

merged 7 commits into from
Aug 7, 2020

Conversation

daniel-arnauer
Copy link
Contributor

Closes #241

@daniel-arnauer daniel-arnauer changed the title Allow disabling/deactivating of users Allow enabling/disabling of users Jun 12, 2020
@openkfwCI
Copy link

openkfwCI commented Jun 12, 2020 •
edited
Loading

NotesTime
✅Note for Reviewer: E2E tests on remote server succeededFri, 07 Aug 2020 07:13:21 +0000

Generated by E2E-Test

@daniel-arnauer daniel-arnauer self-assigned this Jun 12, 2020
@daniel-arnauer daniel-arnauer force-pushed the deactivating-user branch 2 times, most recently from 2a6e3f5 to beef86e Compare June 30, 2020 07:34
@daniel-arnauer daniel-arnauer force-pushed the deactivating-user branch 5 times, most recently from 3458103 to 4b32e98 Compare July 21, 2020 11:13
Stezido
Stezido suggested changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@Stezido Stezido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed the API code only.

CHANGELOG.md Outdated Show resolved Hide resolved
api/src/service/domain/organization/user_disable.spec.ts Outdated Show resolved Hide resolved
api/src/service/domain/organization/user_disable.spec.ts Show resolved Hide resolved
api/src/service/domain/organization/user_disable.spec.ts Outdated Show resolved Hide resolved
api/src/service/domain/organization/user_disable.spec.ts Outdated Show resolved Hide resolved
api/src/service/domain/organization/user_password_change.spec.ts Outdated Show resolved Hide resolved
api/src/service/user_disable.ts Outdated Show resolved Hide resolved
api/src/service/user_enable.ts Outdated Show resolved Hide resolved
api/src/user_disable.ts Outdated Show resolved Hide resolved
api/src/user_enable.ts Outdated Show resolved Hide resolved
Stezido
Stezido suggested changes Jul 22, 2020
View reviewed changes
e2e-test/cypress/support/commands.js Outdated Show resolved Hide resolved
frontend/src/pages/Common/Permissions/PermissionSelection.js Outdated Show resolved Hide resolved
frontend/src/pages/Login/LoginPage.js Outdated Show resolved Hide resolved
frontend/src/pages/Login/reducer.js Outdated Show resolved Hide resolved
frontend/src/pages/Users/UserManagementContainer.js Outdated Show resolved Hide resolved
frontend/src/pages/Users/Users.js Outdated Show resolved Hide resolved
frontend/src/pages/Users/Users.js Outdated Show resolved Hide resolved
frontend/src/pages/Users/Users.js Outdated Show resolved Hide resolved
frontend/src/sagas.js Outdated Show resolved Hide resolved
frontend/src/pages/Users/UsersTable.js Outdated Show resolved Hide resolved
@daniel-arnauer daniel-arnauer force-pushed the deactivating-user branch 2 times, most recently from 5448ecd to 7066827 Compare July 29, 2020 09:24
Stezido
Stezido suggested changes Jul 29, 2020
View reviewed changes
api/src/service/domain/organization/user_disable.spec.ts Outdated Show resolved Hide resolved
api/src/service/domain/organization/user_enable.spec.ts Outdated Show resolved Hide resolved
api/src/service/domain/workflow/user_assignments.ts Show resolved Hide resolved
api/src/service/domain/workflow/user_assignments_get.ts Outdated Show resolved Hide resolved
api/src/service/user_assignments_get.ts Outdated Show resolved Hide resolved
api/src/service/user_disable.ts Outdated Show resolved Hide resolved
api/src/service/user_disable.ts Outdated Show resolved Hide resolved
api/src/service/user_enable.ts Outdated Show resolved Hide resolved
api/src/service/user_enable.ts Outdated Show resolved Hide resolved
Stezido
Stezido suggested changes Jul 29, 2020
View reviewed changes
frontend/src/sagas.js Outdated Show resolved Hide resolved
frontend/src/sagas.js Show resolved Hide resolved
frontend/src/pages/Login/reducer.js Outdated Show resolved Hide resolved
frontend/src/pages/Login/LoginPage.js Outdated Show resolved Hide resolved
frontend/src/pages/Login/actions.js Outdated Show resolved Hide resolved
frontend/src/pages/Login/LoginPageContainer.js Outdated Show resolved Hide resolved
@daniel-arnauer daniel-arnauer force-pushed the deactivating-user branch 3 times, most recently from 495578a to c17d8cd Compare August 3, 2020 10:08
Stezido
Stezido suggested changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@Stezido Stezido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notifications are not working anymore e.g. on users page
user create button is missing correct styles
make sure data-test props are written in snake case

api/src/service/user_assignments_get.ts Outdated Show resolved Hide resolved
frontend/src/pages/Common/CreateButton.js Outdated Show resolved Hide resolved
frontend/src/pages/Overview/OverviewContainer.js Outdated Show resolved Hide resolved
@Stezido Stezido assigned daniel-arnauer and unassigned Stezido Aug 4, 2020
daniel-arnauer added 5 commits August 5, 2020 17:19
API: Fix security issue for user.changePassword
da03504 
Added conditional check in API to ensure that the user belongs to the right organization
API: Add global.disableUser and global.enableUser Intents
d354650 
This endpoints will revoke or grant the user.authenticate permission.
If a user gets disabled, the user is not allowed to be assigned to
any project/subproject/workflowitem, otherwise an error-message
with information about these assignments is thrown. With disabling or
enabling, all permissions of the users remain unaffected except
'user.authenticate'.
Resolves #241
UI: Add feature to disable and enable users
7dbee1e 
Users can now be disabled and enabled at the /users site.
If an user gets disabled, this user dissappears everywhere except
the 'DISABLED USERS' tab. Before disabling an user, this user has
to be unassigned from all project/subproject/workflowitem.
If the user is still assigned to an
project/subproject/workflowitem, the snackbar shows up with an
error message.
Resolves #241
Add e2e-tests
079a41d
Add CHANGELOG.md
d311a19
Stezido
Stezido suggested changes Aug 6, 2020
View reviewed changes
doc/wiki/User-Guide/Permissions.md Outdated Show resolved Hide resolved
@daniel-arnauer daniel-arnauer merged commit b6d71fe into master Aug 7, 2020
@Stezido Stezido deleted the deactivating-user branch October 7, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stezido Stezido Stezido approved these changes

Assignees

@Stezido Stezido

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow disabling of user
3 participants
@daniel-arnauer @openkfwCI @Stezido