ui: Reset state for workflow item history when changing tabs #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathiashoeld
force-pushed
the
317-fix-crashing-history
branch
2 times, most recently
from
224e03f to
1fb6c4f
Compare
gonzochic
requested changes
Jun 11, 2019
| @@ -35,7 +35,8 @@ export default function reducer(state = initialState, action) { | |||
| currentHistoryPage: action.currentHistoryPage, | |||
| isHistoryLoading: false | |||
| }); | |||
|
|
|||
| case CLOSE_WORKFLOWITEM_HISTORY: | |||
| return initialState; | |||
| case CLOSE_WORKFLOWITEM_DETAILS: | |||
There was a problem hiding this comment.
Use fallthrough and handle logout action
There was a problem hiding this comment.
also added the LOGOUT action here
| @@ -144,6 +145,12 @@ function WorkflowDetails({ | |||
| }, | |||
| [showWorkflowDetails] | |||
| ); | |||
| useEffect( | |||
There was a problem hiding this comment.
The effect is called every time, even if it is not necessary. I believe this hook has to move into the component itself.
There was a problem hiding this comment.
changed implementation of <WorkflowitemHistoryTab> to class based and used componentWillUnmount to reset state
mathiashoeld
force-pushed
the
317-fix-crashing-history
branch
from
2fa66be to
af0daf7
Compare
gonzochic
requested changes
Jun 11, 2019
| import { fetchNextWorkflowitemHistoryPage, resetWorkflowitemHistory } from "./actions"; | ||
|
|
||
| class WorkflowitemHistoryTab extends React.Component { | ||
| constructor(props) { |
When a user views the workflow item details and clicks on history and then back to another tab, the history state is now reset, so the calculation of offset and limit are correct. Add e2e test that makes sure this does not happen again. Refactor e2e tests, so that 'data-test' is used instead of 'id'. Closes #317 Rework based on review - Moved WorkflowitemHistoryTab into Workflows - Rewrote WorkflowitemHistory to class based component - Removed effect hook for resetting history state and moved it to ComponentWillUnmount - Fixed e2e-tests - Added LOGOUT action to WorkflowitemHistory reducer
mathiashoeld
force-pushed
the
317-fix-crashing-history
branch
2 times, most recently
from
73a7d79 to
d7ef6e5
Compare
gonzochic
approved these changes
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When a user views the workflow item details and clicks on history and
then back to another tab, the history state is now reset, so the
calculation of offset and limit are correct.
Add e2e test that makes sure this does not happen again.
Refactor e2e tests, so that 'data-test' is used instead of 'id'.
Related issues
Closes #317
How to test
When viewing a workflow item's history, there should be no issues.