Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: fixed deleting tags #2027

Merged
merged 1 commit into from
Oct 18, 2024
Merged

ui: fixed deleting tags #2027

merged 1 commit into from
Oct 18, 2024

Conversation

SamuelPull
Copy link
Collaborator

Checklist

  • I have followed (at least) the PR section of the contributing guide.
  • I fixed all necessary PR warnings
  • The commit history is clean
  • The E2E tests are passing
  • If possible, the issue has been divided into more subtasks
  • I did a self review before requesting a review from another team member

Description

When editing a project and only deleting tags, submit button is disabled.

How to test

  1. edit a project that has one or more tags
  2. delete a tag
  3. submit button should be enabled
  4. ...

Closes #2026

@github-actions GitHub Actions
Copy link

Warnings
⚠️ No CHANGELOG added.
⚠️ There were changes in the frontend, but no E2E-test was added or modified!

Generated by 🚫 dangerJS against 942237a

@openkfwCI
Copy link

openkfwCI commented Oct 18, 2024 •
edited
Loading

NotesTime
✅Note for Reviewer: E2E tests on pipeline 60630 on remote server succeededFri, 18 Oct 2024 09:36:09 +0000

Generated by E2E-Test

@pmolnar-dev pmolnar-dev merged commit c95ebdd into main Oct 18, 2024
30 checks passed
@pmolnar-dev pmolnar-dev deleted the 2026-delete-tags branch October 18, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmolnar-dev pmolnar-dev pmolnar-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui: Cannot submit project edit when deleting tags
3 participants
@SamuelPull @openkfwCI @pmolnar-dev