Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2018: Add remove button for DocumentUpload #2020

Merged
merged 4 commits into from
Oct 15, 2024
Merged

2018: Add remove button for DocumentUpload #2020

merged 4 commits into from
Oct 15, 2024

Conversation

pmolnar-dev
Copy link
Collaborator

@pmolnar-dev pmolnar-dev commented Oct 14, 2024 •
edited
Loading

Checklist

  • I have followed (at least) the PR section of the contributing guide.
  • I fixed all necessary PR warnings
  • The commit history is clean
  • The E2E tests are passing
  • If possible, the issue has been divided into more subtasks
  • I did a self review before requesting a review from another team member

Description

How to test

  1. <E.g. login as user XYZ>
  2. <E.g. try to create new subproject>
  3. <E.g. You should not see error in console>
  4. ...

Closes #2018

Closes ModifyMe

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 14, 2024 •
edited
Loading

Warnings
⚠️ No CHANGELOG added.
⚠️ There were changes in the frontend, but no E2E-test was added or modified!

Generated by 🚫 dangerJS against fc0c5bd

@openkfwCI
Copy link

openkfwCI commented Oct 14, 2024 •
edited
Loading

NotesTime
✅Note for Reviewer: E2E tests on pipeline 60603 on remote server succeededMon, 14 Oct 2024 09:54:08 +0000

Generated by E2E-Test

@SamuelPull SamuelPull merged commit 09fd1ee into main Oct 15, 2024
30 checks passed
@SamuelPull SamuelPull deleted the 2018-add-remove-button branch October 15, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelPull SamuelPull SamuelPull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Remove button for each document/external link in DocumentUpload modal
3 participants
@pmolnar-dev @openkfwCI @SamuelPull