Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed workflow items are sorted randomly #1557

Closed
1 task done
schoel-bis opened this issue Dec 6, 2023 · 1 comment · Fixed by #1565
Closed
1 task done

Closed workflow items are sorted randomly #1557

schoel-bis opened this issue Dec 6, 2023 · 1 comment · Fixed by #1565
Assignees
@SamuelPull
Labels
api Indicates api related issue or feature bug Something isn't working
Milestone
TruBudget 2.6.0

Comments

@schoel-bis
Copy link

  • I have searched the issues of this repository and believe that this is not a duplicate.

Description 😯

Closed Workflow items are sorted in random order. The items 1, 2, and 3 in the screen below were originally ordered as 1, 3, 2 and also closed in this order. The timestamps on the worflowitem_closed events are 2023-12-06T11:58:24.925Z and 2023-12-06T11:57:41.375Z respectively for items 2 and 3, i.e. the timestamps actually say that item 3 was closed before item 2.

Bildschirmfoto vom 2023-12-06 13-25-17

How to reproduce 🕹

Set up a workflow and close items. Observe random ordering.

Your Environment 🌎

All 2.5
@schoel-bis schoel-bis added the bug Something isn't working label Dec 6, 2023
@SamuelPull SamuelPull self-assigned this Dec 7, 2023
@SamuelPull
Copy link
Collaborator

SamuelPull commented Dec 7, 2023 •
edited
Loading

This is a regreession.

AssertionError Expected close event for workflowitem isn't logged anywhere. Point of failure is function closedAt in src/domain/workflow/workflowitem_ordering. Origin is empty workflowitem.log - there should be events associated with wfi.

sourceWorkflowitems seems to have been used in setting workflowitem.log, which keeps track of events associated with workflowitem. presently it is unused.

  • assertion error should not be silenced. at least log it visibly
  • closed workflowitems should be correctly sorted

@SamuelPull SamuelPull added the api Indicates api related issue or feature label Dec 8, 2023
@SamuelPull SamuelPull mentioned this issue Dec 11, 2023
Merged
6 tasks
@SamuelPull SamuelPull added this to the TruBudget 2.6.0 milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SamuelPull SamuelPull

Labels
api Indicates api related issue or feature bug Something isn't working
Projects
None yet
Milestone
TruBudget 2.6.0
Development

Successfully merging a pull request may close this issue.

api: source wfis with log to fix random sorting of workflowitems openkfw/TruBudget
2 participants
@schoel-bis @SamuelPull