Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8337422: spelling error in jlink documentation #20882

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sundararajana
Copy link
Member

@sundararajana sundararajana commented Sep 6, 2024

fixed spelling to be consistent with the rest of the man page.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8337422: spelling error in jlink documentation

Issue

  • JDK-8337422: spelling error in jlink documentation (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20882/head:pull/20882
$ git checkout pull/20882

Update a local copy of the PR:
$ git checkout pull/20882
$ git pull https://git.openjdk.org/jdk.git pull/20882/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20882

View PR using the GUI difftool:
$ git pr show -t 20882

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20882.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 6, 2024

👋 Welcome back sundar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 6, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 6, 2024
@openjdk
Copy link

openjdk bot commented Sep 6, 2024

@sundararajana The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Sep 6, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 6, 2024

Webrevs

github-actions bot pushed a commit to dougxc/openjdk-pr-canary that referenced this pull request Sep 6, 2024
8337422: spelling error in jlink documentation
@pavelrappo
Copy link
Member

I'm not an expert here, but I remember vividly that "dependence" might not be a misspelling/typo in the world of modules. There are semantic differences which necessitate two different words. Please double check.

@AlanBateman
Copy link
Contributor

I checked the OED and it does seem to be uncountable, which makes me wonder about other places, e.g. JLS 7.7.1.

@sundararajana
Copy link
Member Author

@AlanBateman @pavelrappo I did double check. "dependence" is an uncountable noun.

https://dictionary.cambridge.org/dictionary/english/dependence

dependence
noun [ U ]

https://www.collinsdictionary.com/dictionary/english/dependence

How do I proceed?

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 7, 2024

@sundararajana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants