-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8337422: spelling error in jlink documentation #20882
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back sundar! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@sundararajana The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
8337422: spelling error in jlink documentation
I'm not an expert here, but I remember vividly that "dependence" might not be a misspelling/typo in the world of modules. There are semantic differences which necessitate two different words. Please double check. |
I checked the OED and it does seem to be uncountable, which makes me wonder about other places, e.g. JLS 7.7.1. |
@AlanBateman @pavelrappo I did double check. "dependence" is an uncountable noun. https://dictionary.cambridge.org/dictionary/english/dependence dependence https://www.collinsdictionary.com/dictionary/english/dependence How do I proceed? |
@sundararajana This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
fixed spelling to be consistent with the rest of the man page.
Progress
Warning
8337422: spelling error in jlink documentation
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20882/head:pull/20882
$ git checkout pull/20882
Update a local copy of the PR:
$ git checkout pull/20882
$ git pull https://git.openjdk.org/jdk.git pull/20882/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 20882
View PR using the GUI difftool:
$ git pr show -t 20882
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20882.diff
Webrev
Link to Webrev Comment