Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: refactoring code of graceful exits #1885

Merged
merged 32 commits into from
Feb 18, 2024
Merged

fix: refactoring code of graceful exits #1885

merged 32 commits into from
Feb 18, 2024

Conversation

luhaoling
Copy link
Contributor

@luhaoling luhaoling commented Feb 5, 2024 •
edited by cubxxw
Loading


🔍 What type of PR is this?

👀 What this PR does / why we need it:

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

🅰 Which issue(s) this PR fixes:

Fixes #1886

📝 Special notes for your reviewer:

🎯 Describe how to verify it

📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.:

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 5, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 5, 2024 •
edited
Loading

Codecov Report

Attention: 85 lines in your changes are missing coverage. Please review.

Comparison is base (760fbc9) 5.32% compared to head (ce83799) 5.32%.
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/common/startrpc/start.go 4.54% 42 Missing ⚠️
internal/msggateway/n_ws_server.go 0.00% 28 Missing ⚠️
pkg/util/genutil/genutil.go 0.00% 10 Missing ⚠️
internal/msggateway/init.go 0.00% 4 Missing ⚠️
internal/tools/cron_task.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##            main   #1885      +/-   ##
========================================
- Coverage   5.32%   5.32%   -0.01%     
========================================
  Files         43      43              
  Lines       3830    3852      +22     
========================================
+ Hits         204     205       +1     
- Misses      3613    3634      +21     
  Partials      13      13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cubxxw cubxxw enabled auto-merge February 18, 2024 12:16
@cubxxw cubxxw added this pull request to the merge queue Feb 18, 2024
Merged via the queue into openimsdk:main with commit c754ec6 Feb 18, 2024
25 checks passed
@github-actions github-actions bot added this to the v3.1 milestone Feb 18, 2024
@openimsdk openimsdk locked and limited conversation to collaborators Feb 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndrewZuo01 AndrewZuo01 AndrewZuo01 left review comments

@openimbot openimbot openimbot approved these changes

@cubxxw cubxxw cubxxw approved these changes

@skiffer-git skiffer-git Awaiting requested review from skiffer-git skiffer-git is a code owner

@FGadvancer FGadvancer Awaiting requested review from FGadvancer FGadvancer is a code owner

@Bloomingg Bloomingg Awaiting requested review from Bloomingg Bloomingg is a code owner

@withchao withchao Awaiting requested review from withchao withchao is a code owner

Assignees
No one assigned
Labels
size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v3.1
Development

Successfully merging this pull request may close these issues.

Bug: refactoring code of graceful exit
5 participants
@luhaoling @AndrewZuo01 @cubxxw @openimbot @FGadvancer