-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support mac deployment and optimization make check #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xinwei Xiong (cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong (cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong (cubxxw) <3293172751nss@gmail.com>
cubxxw
requested review from
FGadvancer,
skiffer-git,
a team,
Bloomingg and
withchao
as code owners
December 16, 2023 11:51
pull-request-size
bot
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Dec 16, 2023
Apply Sweep Rules to your PR?
|
Signed-off-by: Xinwei Xiong (cubxxw) <3293172751nss@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1570 +/- ##
=====================================
Coverage 4.88% 4.88%
=====================================
Files 42 42
Lines 3787 3787
=====================================
Hits 185 185
Misses 3592 3592
Partials 10 10 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Xinwei Xiong (cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong (cubxxw) <3293172751nss@gmail.com>
Signed-off-by: Xinwei Xiong (cubxxw) <3293172751nss@gmail.com>
openimbot
approved these changes
Dec 16, 2023
kubbot
approved these changes
Dec 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 What type of PR is this?
/kind feature
👀 What this PR does / why we need it:
Body:
This PR addresses critical issues faced by users when deploying OpenIM on macOS, providing necessary fixes and improvements to streamline the deployment process.
Key Highlights:
make check
command encountered difficulties in correctly identifying and displaying available ports. This PR introduces a refined approach to port checking, enhancing the accuracy and reliability of the process.Before and After the Changes:
Before the Changes:
After the Changes:
🅰 Which issue(s) this PR fixes:
Fixes #1569
📝 Special notes for your reviewer:
🎯 Describe how to verify it
github CICD
OR local os:
📑 Additional documentation e.g., RFC, notion, Google docs, usage docs, etc.: