#137 Making NSURLSession extensible #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahmharsh
force-pushed
the
nsurlsession
branch
from
287a07a to
d3888fb
Compare
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
==========================================
+ Coverage 80.09% 80.19% +0.09%
==========================================
Files 41 43 +2
Lines 3447 3463 +16
Branches 146 147 +1
==========================================
+ Hits 2761 2777 +16
Misses 686 686
Continue to review full report at Codecov.
|
shahmharsh
force-pushed
the
nsurlsession
branch
from
d3888fb to
e16b8aa
Compare
shahmharsh
force-pushed
the
nsurlsession
branch
from
e16b8aa to
69d0b3b
Compare
|
@shahmharsh I see the signed individual contributor CLA for you, thanks for doing that. @protocol86 will be reviewing this change for you. |
protocol86
reviewed
Nov 1, 2017
| NSURLSession *customSession = [NSURLSession sessionWithConfiguration:config]; | ||
| [OIDURLSessionProvider setSession:customSession]; | ||
| NSURLSession *session = [OIDURLSessionProvider session]; | ||
| XCTAssertEqual(session, customSession); |
There was a problem hiding this comment.
Please use XCTAssertEqualObjects here.
Source/OIDURLSessionProvider.m
Outdated
|
|
||
| NS_ASSUME_NONNULL_BEGIN | ||
|
|
||
| static NSURLSession * __nullable gURLSession; |
|
@protocol86 comments addressed |
protocol86
approved these changes
Nov 2, 2017
|
When can I expect this to be merged and released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #137