Resolved the "-Wpartial-availability" warning. #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamDenniss
force-pushed
the
issue146
branch
from
22d7af7 to
7745f77
Compare
Codecov Report
@@ Coverage Diff @@
## master #158 +/- ##
==========================================
- Coverage 80.11% 80.09% -0.02%
==========================================
Files 41 41
Lines 3444 3447 +3
Branches 144 146 +2
==========================================
+ Hits 2759 2761 +2
- Misses 685 686 +1
Continue to review full report at Codecov.
|
WilliamDenniss
force-pushed
the
issue146
branch
from
7745f77 to
3df11bd
Compare
WilliamDenniss
force-pushed
the
issue146
branch
from
3df11bd to
7dd30d6
Compare
Implemented dismiss functionality for SFAuthenticationSession on iOS 11. Removed GCC_TREAT_WARNINGS_AS_ERRORS=YES from the Podspec, enabled `-Werror` for TravisCI instead to catch new warnings at the library-developer level. AppAuth now requires a Base SDK of iOS 11 (still supports iOS 7 as a Deployment Target).
WilliamDenniss
force-pushed
the
issue146
branch
from
7dd30d6 to
1ffac3c
Compare
|
@WilliamDenniss - Can you please make new tag for this change, because currently is it throwing errors on SFSafariViewController when integrating the framework. Thanks |
shankari
added a commit
to shankari/cordova-jwt-auth
that referenced
this pull request
Jan 18, 2018
Issue openid/AppAuth-iOS#146 Fix openid/AppAuth-iOS#158 Release in https://github.com/openid/AppAuth-iOS/releases/tag/0.91.0 > Fixes several "availability" warnings and errors. Corrects deployment targets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented dismiss functionality for SFAuthenticationSession on iOS 11.
Removed GCC_TREAT_WARNINGS_AS_ERRORS=YES from the Podspec, enabled
-Werrorfor TravisCI instead to catch new warnings at the library-developer level.AppAuth now requires a Base SDK of iOS 11 (still supports iOS 7 as a Deployment Target).
Fixes #146