Updates AppAuth for Xcode 9 #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamDenniss
requested changes
Sep 28, 2017
|
Sorry about that, I've now put it back. The ones that are removed are for the tests targets, which are still set to run as Debug, and because Build Active Architecture Only is set to YES in Debug, it still won't build it in fat, so that setting is unnecessary in my opinion (only for tests targets, it's necessary for the framework and static lib) |
WilliamDenniss
approved these changes
Sep 28, 2017
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves some project and code warnings.
Updates Swift for iOS tests to Swift 4. This means that iOS tests can only be run with Xcode 9
Tested that Xcode 8.3.3 builds correctly, with the exception of iOS tests (because of Swift 4)