Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rustpotterks] initial contribution #12606

Merged
merged 12 commits into from
Jun 19, 2022
Merged

[rustpotterks] initial contribution #12606

merged 12 commits into from
Jun 19, 2022

Conversation

GiviMAD
Copy link
Member

@GiviMAD GiviMAD commented Apr 15, 2022 •
edited
Loading

Signed-off-by: Miguel Álvarez Díez miguelwork92@gmail.com
WORK IN PROGRESS
New keyword spotter.

The underling library is mine, still need to improve some things there before it can be merged.

Right now is working.

Models can be generated through this CLI:
https://github.com/GiviMAD/rustpotter-cli

Related source:
https://github.com/GiviMAD/rustpotter
https://github.com/GiviMAD/rustpotter-java

@GiviMAD
[rustpotterks] initial contribution
3e40a37 
Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
@GiviMAD GiviMAD requested a review from a team as a code owner April 15, 2022 08:18
@lolodomo lolodomo added the work in progress A PR that is not yet ready to be merged label Apr 25, 2022
@GiviMAD
use rustpotter 0.8.1
e807c44 
Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
@GiviMAD
use rustpotter 0.9.1
1d3202d 
Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
@GiviMAD
use rustpotter 0.10.0; support any bit depth
32c1900 
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
@GiviMAD
support for big-endian
3ab4119 
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
@GiviMAD
final implementation and docs
e0260bd 
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
@GiviMAD GiviMAD mentioned this pull request Jun 15, 2022
Merged
lolodomo
lolodomo requested changes Jun 15, 2022
View reviewed changes
...otterks/src/main/java/org/openhab/voice/rustpotterks/internal/RustpotterKSConfiguration.java Show resolved Hide resolved
...otterks/src/main/java/org/openhab/voice/rustpotterks/internal/RustpotterKSConfiguration.java Show resolved Hide resolved
...otterks/src/main/java/org/openhab/voice/rustpotterks/internal/RustpotterKSConfiguration.java Show resolved Hide resolved
bundles/org.openhab.voice.rustpotterks/src/main/resources/OH-INF/config/config.xml Outdated Show resolved Hide resolved
....rustpotterks/src/main/java/org/openhab/voice/rustpotterks/internal/RustpotterKSService.java Outdated Show resolved Hide resolved
bundles/org.openhab.voice.rustpotterks/src/main/resources/OH-INF/config/config.xml Outdated Show resolved Hide resolved
bundles/org.openhab.voice.rustpotterks/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.voice.rustpotterks/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.voice.rustpotterks/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.voice.rustpotterks/README.md Outdated Show resolved Hide resolved
@lolodomo
Copy link
Contributor

And please also generate the default translations file.

@GiviMAD GiviMAD changed the title [WIP][rustpotterks] initial contribution [rustpotterks] initial contribution Jun 17, 2022
@GiviMAD
apply pr review and update lib
6a31a26 
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
@GiviMAD
apply pr review
63d5f3a 
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
@GiviMAD
fix typo
a6c73ba 
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
@GiviMAD GiviMAD requested a review from lolodomo June 17, 2022 14:44
@GiviMAD
fix parameter group name
1f910ee 
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
@lolodomo lolodomo removed the work in progress A PR that is not yet ready to be merged label Jun 18, 2022
@lolodomo
Copy link
Contributor

And in README and in setting label/description, you are using sometimes "wakeword(s)" and "wake word(s)". I believe the correct English is two words, so "wake word(s)".

@GiviMAD
apply pr review
a1d4374 
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
@GiviMAD GiviMAD requested a review from lolodomo June 18, 2022 11:48
@GiviMAD
Copy link
Member Author

GiviMAD commented Jun 18, 2022

@lolodomo one side question.
What would be the best French translation of "hey home" for adding to the web demo?
"Salut à la maison" seems too long for me for a wake word. Or that one is the best?

@lolodomo
Copy link
Contributor

@GiviMAD : remains two small comments about setting description + your Objects.requireNonNull

@lolodomo one side question.
What would be the best French translation of "hey home" for adding to the web demo?
"Salut à la maison" seems too long for me for a wake word. Or that one is the best?

Too long and wrong translation ;) I would suggest "Hé, maison"

@GiviMAD
apply pr review
633f32f 
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
@GiviMAD
Copy link
Member Author

GiviMAD commented Jun 19, 2022

@lolodomo, I think is ready.

@lolodomo
Copy link
Contributor

@lolodomo, I think is ready.

Yes, I think too.

lolodomo
lolodomo approved these changes Jun 19, 2022
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@lolodomo lolodomo merged commit 11aa320 into openhab:main Jun 19, 2022
@lolodomo lolodomo added this to the 3.3 milestone Jun 19, 2022
@GiviMAD GiviMAD deleted the rustpotterks branch June 19, 2022 09:38
@GiviMAD GiviMAD mentioned this pull request Jul 4, 2022
Merged
leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022
@GiviMAD @leifbladt
[rustpotterks] initial contribution (openhab#12606)
cfa80d0 
* [rustpotterks] initial contribution

Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
@GiviMAD @andan67
[rustpotterks] initial contribution (openhab#12606)
f61630a 
* [rustpotterks] initial contribution

Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
@GiviMAD @andrasU
[rustpotterks] initial contribution (openhab#12606)
45d7722 
* [rustpotterks] initial contribution

Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
@GiviMAD @psmedley
[rustpotterks] initial contribution (openhab#12606)
ddfcc8e 
* [rustpotterks] initial contribution

Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
@GiviMAD @nemerdaud
[rustpotterks] initial contribution (openhab#12606)
47f9c20 
* [rustpotterks] initial contribution

Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

Assignees
No one assigned
Labels
new voice
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
2 participants
@GiviMAD @lolodomo