-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lifx] Improve firmware version support #10384
Merged
kaikreuzer
merged 2 commits into
openhab:main
from
wborn:lifx-improve-firmware-version-support
Mar 24, 2021
Merged
[lifx] Improve firmware version support #10384
kaikreuzer
merged 2 commits into
openhab:main
from
wborn:lifx-improve-firmware-version-support
Mar 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
When the firmware of a light is upgraded the supported features can change. With these changes the binding uses the features based on the light firmware version. Also corrects some of the temperature ranges based on the LIFX products description. Signed-off-by: Wouter Born <github@maindrain.net>
wborn
force-pushed
the
lifx-improve-firmware-version-support
branch
from
March 24, 2021 11:23
3897eaa
to
e59fa42
Compare
kaikreuzer
requested changes
Mar 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, thanks! Only a very minimalistic comment :-)
...es/org.openhab.binding.lifx/src/main/java/org/openhab/binding/lifx/internal/LifxProduct.java
Outdated
Show resolved
Hide resolved
…ding/lifx/internal/LifxProduct.java Co-authored-by: Kai Kreuzer <kai@openhab.org>
kaikreuzer
approved these changes
Mar 24, 2021
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
* [lifx] Improve firmware version support When the firmware of a light is upgraded the supported features can change. With these changes the binding uses the features based on the light firmware version. Also corrects some of the temperature ranges based on the LIFX products description. Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: John Marshall <john.marshall.au@gmail.com>
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
computergeek1507
pushed a commit
to computergeek1507/openhab-addons
that referenced
this pull request
Jul 13, 2021
* [lifx] Improve firmware version support When the firmware of a light is upgraded the supported features can change. With these changes the binding uses the features based on the light firmware version. Also corrects some of the temperature ranges based on the LIFX products description. Signed-off-by: Wouter Born <github@maindrain.net>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
* [lifx] Improve firmware version support When the firmware of a light is upgraded the supported features can change. With these changes the binding uses the features based on the light firmware version. Also corrects some of the temperature ranges based on the LIFX products description. Signed-off-by: Wouter Born <github@maindrain.net>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* [lifx] Improve firmware version support When the firmware of a light is upgraded the supported features can change. With these changes the binding uses the features based on the light firmware version. Also corrects some of the temperature ranges based on the LIFX products description. Signed-off-by: Wouter Born <github@maindrain.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the firmware of a light is upgraded the supported features can change.
With these changes the binding uses the features based on the light firmware version.
Also corrects some of the temperature ranges based on the LIFX products description.
See: LIFX/products#12