Fixes #7707, #7708 health snapshot, custom report #7709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made it so the custom report foudn in patient_report.php uses twig and also has a filter event for customizing the data that gets passed into the report selection system. This allows module writers to extend the interface and add data or hide sections as needed. Did the same thing with the health snapshot to allow pieces of the snapshot to be overriden by twig templates. This work was done to facilitate a module that wanted to have flags to hide/show different parts of the reports and health snapshot as they pilot test these areas with their patients. Fixes openemr#7707 Fixes openemr#7708
bradymiller
reviewed
Sep 14, 2024
portal/home.php
Outdated
| @@ -31,6 +31,8 @@ | |||
| use Twig\Error\LoaderError; | |||
| use Twig\Error\RuntimeError; | |||
| use Twig\Error\SyntaxError; | |||
| use OpenEMR\Events\PatientReport\PatientReportFilterEvent; | |||
| use OpenEMR\Common\Logging\SystemLogger; | |||
bradymiller
reviewed
Sep 14, 2024
| use OpenEMR\Controllers\Portal\PortalPatientReportController; | ||
| use OpenEMR\Common\Twig\TwigContainer; | ||
| use OpenEMR\Events\PatientReport\PatientReportFilterEvent; | ||
| use Twig\Error\SyntaxError; |
bradymiller
reviewed
Sep 14, 2024
| { | ||
|
|
||
| // show available documents | ||
| $db = $GLOBALS['adodb']['db']; |
There was a problem hiding this comment.
is above $db variable being used?
bradymiller
reviewed
Sep 14, 2024
| <td> </td> | ||
| <td> | ||
| <label class="d-block" for='issue_{{ issue.id|attr }}'> | ||
| <input type='checkbox' name='issue_{{ issue.id|attr }}' id='issue_{{ issue.id|attr }}' class='issuecheckbox' value='/{{ issue.encounter|join("/")|text }}' /> |
There was a problem hiding this comment.
attr for the value attribute
bradymiller
reviewed
Sep 14, 2024
| <label> | ||
| <input type="checkbox" name="{{ form.formdir|attr }}_{{ form.form_id|attr }}" | ||
| id="{{ form.formdir|attr }}_{{ form.form_id|attr }}" | ||
| value="{{ form.encounter|attr }}" class="encounter_form">{{ form.display|attr }} ({{ form.date|date("Y-m-d")|attr }}) |
There was a problem hiding this comment.
only need text for the form.display and form.date
|
@adunsulag , just noted several minor issues. Otherwise code looks good for bringing in. |
|
Fixed all the issues, if CI passes, will bring in to avoid holding up patch. |
sjpadgett
pushed a commit
to sjpadgett/openemr
that referenced
this pull request
Sep 22, 2024
…emr#7709) * Fixes openemr#7707, openemr#7708 health snapshot, custom report Made it so the custom report foudn in patient_report.php uses twig and also has a filter event for customizing the data that gets passed into the report selection system. This allows module writers to extend the interface and add data or hide sections as needed. Did the same thing with the health snapshot to allow pieces of the snapshot to be overriden by twig templates. This work was done to facilitate a module that wanted to have flags to hide/show different parts of the reports and health snapshot as they pilot test these areas with their patients. Fixes openemr#7707 Fixes openemr#7708 * Fix code styles. * Add copyright notice * style fixes, escaping fixes (cherry picked from commit 4d8d535)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made it so the custom report foudn in patient_report.php uses twig and also has a filter event for customizing the data that gets passed into the report selection system. This allows module writers to extend the interface and add data or hide sections as needed.
Did the same thing with the health snapshot to allow pieces of the snapshot to be overridden by twig templates.
This work was done to facilitate a module that wanted to have flags to hide/show different parts of the reports and health snapshot as they pilot test these areas with their patients.
Fixes #7707
Fixes #7708