Portal Quick Start refactor #7117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pull quickstart dashboard from iFrame embed in home page twig - fix nav topNav syntax
- add events to inject new cards in dashboard - modify existing portal render event class to include new events for cards.
|
My plan is to create a portal addon module with first addon of patient upload images/documents. Currently that feature is already in portal code but I will move it to the new module. I'm a little apprehensive concerning event firing for JS injection but I think moving the dashboard to render and fire dashboard events last instead of first will better manage DOMs notice. Could be wrong and if so let me know. I'll merge this before doing module in case others want to take advantage. |
|
Merging so I can create a new portal module to allow easy plugin additions to dashboard and homepage SPA and Robert Jones can test his ideas. |
|
nice!
|
sjpadgett
added a commit
to sjpadgett/openemr
that referenced
this pull request
Feb 21, 2024
* Portal Quick Start refactor - Pull quickstart dashboard from iFrame embed in home page twig - fix nav topNav syntax * refactor quickstart cardto twig * - Move Dasboard template to render last on page - add events to inject new cards in dashboard - modify existing portal render event class to include new events for cards. * - add me to authorship * - delete obsalete quickstart page. (cherry picked from commit f6b4fef)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7116
Short description of what this resolves:
Refactor landing quickstart to prepare for plugin integration
Changes proposed in this pull request: