Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Endpoints for Prescription/MedicationRequest Resource #3821

Merged
merged 11 commits into from
Aug 16, 2020

Conversation

yashrajbothra
Copy link
Contributor

Fixes #

Short description of what this resolves:

Changes proposed in this pull request:

  • Added Prescription Endpoints
  • Added MedicationRequest Endpoints
  • Changed Drug Code to support only RXCUI Code

Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
@yashrajbothra
Copy link
Contributor Author

yashrajbothra commented Aug 6, 2020

var msg = opener.set_related(codetype, code, selector, codedesc);

The callback in find_code_dynamic doesn't support target. Should we add sel_related_target like this
opener.set_related_target(codetype, code, selector, codedesc, target_element);

Or is there some other way to do this?

If needed to get something to work, then go for it :)

Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
@bradymiller
Copy link
Member

travis is pointing out a php deprecated error for 7.4 and 8.0:

------------------------------
Checking for PHP syntax errors
------------------------------
PHP Deprecated:  Cannot use "parent" when current class scope has no parent in ./src/Services/FHIR/FhirMedicationRequestService.php on line 28
---------------------------------------

LEFT JOIN users AS practitioner
ON practitioner.id = prescriptions.provider_id
LEFT JOIN drugs AS drug
ON drug.drug_id = prescriptions.drug_id";

This comment was marked as resolved.

Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
@bradymiller
Copy link
Member

hi @yashrajbothra , Just let me know when this is ready for final testing before bringing into codebase. thanks! -brady

@yashrajbothra yashrajbothra marked this pull request as ready for review August 8, 2020 08:53
@yashrajbothra
Copy link
Contributor Author

Hii @bradymiller , All Endpoints are testing well. But the frontend part is not testing well because of the callback sel_rel() . The data after selecting code are adding to related to although it should be added to RXCUI Code I think we need to change callback to sel_rel_target. Also how can we limit the modal to select only one code?

yashrajbothra and others added 3 commits August 14, 2020 17:16
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
@yashrajbothra
Copy link
Contributor Author

Hello @bradymiller Sir, Pushed a fix for Target Element and Added Limit in the Popup. Kindly Review :)

Thanks :)

@bradymiller
Copy link
Member

hi @yashrajbothra ui and rxnorm stuff is testing well. I'm assuming the api endpoints are testing well for you, so bringing this in. thanks for the FHIR endpoints! -brady

@bradymiller bradymiller merged commit 8a6e27e into openemr:master Aug 16, 2020
@yashrajbothra yashrajbothra deleted the med_req_res branch August 16, 2020 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants