Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading AllergyIntolerance Resource #3736

Merged
merged 24 commits into from
Jul 24, 2020

Conversation

yashrajbothra
Copy link
Contributor

Signed-off-by: Yash Bothra yashrajbothra786@gmail.com

Changes proposed in this pull request:

  • Added New Standard AllergyIntolrence Resource Endpoints
  • Upgraded FHIR AllergyIntolrence Resource

Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
@yashrajbothra yashrajbothra marked this pull request as draft July 12, 2020 05:23
@yashrajbothra
Copy link
Contributor Author

Need to add verificationStatus and code

Couldn't find any relatable field to map with 🤔

Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
@tywrenn
Copy link
Contributor

tywrenn commented Jul 14, 2020

@yashrajbothra There are conflicting files. Please rebase & fix

@yashrajbothra yashrajbothra marked this pull request as ready for review July 14, 2020 13:43
@yashrajbothra
Copy link
Contributor Author

Done! Thanks, @tywrenn 👍

_rest_routes.inc.php Outdated Show resolved Hide resolved
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
@yashrajbothra
Copy link
Contributor Author

Thanks, @bradymiller for the review. Pushed the fix :)

yashrajbothra and others added 4 commits July 17, 2020 16:54
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
@tywrenn
Copy link
Contributor

tywrenn commented Jul 18, 2020

@yashrajbothra Travis isn't happy

@yashrajbothra
Copy link
Contributor Author

Lol, @bradymiller Looks like Travis needs a Health-Checkup :)

@bradymiller
Copy link
Member

yep, will look into the travis issue soon. rec ignoring travis for now since it's unrelated to anything being worked on.

@bradymiller
Copy link
Member

hi @yashrajbothra , getting close :)
Noted a couple issues above. Just let me know when addressed and is testing well for you. then will bring this in.

Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
@yashrajbothra
Copy link
Contributor Author

Done with all fixes 👍

interface/patient_file/summary/add_edit_issue.php Outdated Show resolved Hide resolved
interface/patient_file/summary/add_edit_issue.php Outdated Show resolved Hide resolved
interface/patient_file/summary/add_edit_issue.php Outdated Show resolved Hide resolved
interface/patient_file/summary/add_edit_issue.php Outdated Show resolved Hide resolved
API_README.md Outdated Show resolved Hide resolved
API_README.md Outdated Show resolved Hide resolved
_rest_routes.inc.php Outdated Show resolved Hide resolved
_rest_routes.inc.php Outdated Show resolved Hide resolved
@bradymiller
Copy link
Member

we found a couple more minor issue to fix up.
(then it should be ready :) )

Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
@yashrajbothra
Copy link
Contributor Author

@tywrenn @bradymiller Thanks for the review. Updated all the fix :)

Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
@bradymiller
Copy link
Member

travis is just plain vengeful :)

tenor (5)

Code looks good and bringing this. Not gonna let travis stall out momentum of fhir. thanks for the improvements @yashrajbothra ! -brady
(I'll fix up the travis stuff in a following commit)

@bradymiller
Copy link
Member

lol @yashrajbothra , looks like you just took down travis:

tenor (35)

@bradymiller bradymiller merged commit 632cf25 into openemr:master Jul 24, 2020
@yashrajbothra yashrajbothra deleted the allergy_res branch July 24, 2020 06:34
@yashrajbothra
Copy link
Contributor Author

Wohooo @bradymiller Time to visit Condition Resource now 😉

@bradymiller
Copy link
Member

hi @yash , posted a commit after with minor fixes:

  1. changed a include_once to a require_once
  2. the verification field was not showing up when editing a already existent allergy so changed the mechanism of displaying it to what is used for the other allergy specific fields
    3e1e77b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants