Immuniazation Resource #3729
Merged
Immuniazation Resource #3729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
bradymiller
reviewed
Jul 10, 2020
bradymiller
reviewed
Jul 10, 2020
bradymiller
reviewed
Jul 10, 2020
bradymiller
reviewed
Jul 10, 2020
bradymiller
reviewed
Jul 10, 2020
bradymiller
reviewed
Jul 10, 2020
bradymiller
reviewed
Jul 10, 2020
bradymiller
reviewed
Jul 10, 2020
bradymiller
reviewed
Jul 10, 2020
| parent::__construct(self::IMMUNIZATION_TABLE); | ||
| $this->uuidRegistery = new UuidRegistry(['table_name' => self::IMMUNIZATION_TABLE]); | ||
| $this->uuidRegistery->createMissingUuids(); | ||
| (new UuidRegistry(['table_name' => self::PATIENT_TABLE]))->createMissingUuids(); |
There was a problem hiding this comment.
this auto-populating uuid stuff is just too cool every time i see it :)
|
hi @yashrajbothra , overall the code looks really good. After above issues are addressed and is testing well for you, then just let me know (then I'll bring it into the codebase); and then onto the next resource :) |
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
bradymiller
reviewed
Jul 10, 2020
bradymiller
reviewed
Jul 10, 2020
bradymiller
reviewed
Jul 10, 2020
bradymiller
reviewed
Jul 10, 2020
Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
yashrajbothra
commented
Jul 10, 2020
src/Common/Uuid/UuidRegistry.php
Outdated
| * Check if UUID String is Empty | ||
| * @return boolean | ||
| */ | ||
| public static function isEmptyStringUUID($uuidString) |
There was a problem hiding this comment.
Not Needed as empty() can be used to check any empty string 👎
bradymiller
reviewed
Jul 11, 2020
|
hi @yashrajbothra , very nice! bringing this in. thanks for the improvements! -brady |
bradymiller
pushed a commit
that referenced
this pull request
Jul 12, 2020
* New Immunization Resource Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com> * Added UUID to Edit Immu. with isValidUUID() Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com> * Fixed Some Issues Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com> * Added FHIR SEARCH Prameter Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com> * Updated Documentation Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com> * fixes Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com> * Some Fixes Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com> * Fix Signed-off-by: Yash Bothra <yashrajbothra786@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading FHIR Immunization Resource with New Standard Endpoints
Changes proposed in this pull request: