Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHPCS errors using PHPCBF #3413

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Fix PHPCS errors using PHPCBF #3413

merged 1 commit into from
Apr 23, 2020

Conversation

prondubuisi
Copy link
Member

Fixes #3412

@bradymiller
Copy link
Member

bradymiller commented Apr 23, 2020 •
edited
Loading

hi @prondubuisi ,
These changes look good and bringing into codebase (I am not sure why these didn't get fixed in the huge update; guessing because the recent https://github.com/squizlabs/PHP_CodeSniffer/releases/tag/3.5.5 version release fixed some bugs with that rule).
Thanks for the fixes! -brady

@bradymiller bradymiller merged commit 70705ea into openemr:master Apr 23, 2020
@prondubuisi
Copy link
Member Author

hi @prondubuisi ,
These changes look good and bringing into codebase (I am not sure why these didn't get fixed in the huge update; guessing because the recent https://github.com/squizlabs/PHP_CodeSniffer/releases/tag/3.5.5 version release fixed some bugs with that rule).
Thanks for the fixes! -brady

Okay, thanks for the extra Info, goes a long way.

@prondubuisi prondubuisi deleted the make-phpcbf-error-fix branch April 24, 2020 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bring in PHPCBF fixes for OpenEMR
2 participants
@prondubuisi @bradymiller