Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(build): build and push images from libcstor #70

Merged
merged 10 commits into from
Sep 9, 2020
Merged

chore(build): build and push images from libcstor #70

merged 10 commits into from
Sep 9, 2020

Conversation

mittachaitu
Copy link

@mittachaitu mittachaitu commented Sep 4, 2020 •
edited
Loading

Signed-off-by: mittachaitu sai.chaithanya@mayadata.io

Pull Request template

Please, go through these steps before you submit a PR. ## Remove this line

Why is this PR required? What issue does it fix?:
This PR is required to fix the licensing issue in cStor repo.

What this PR does?:
This PR does the following changes:

  • Moves the zrepl.c from cstor/cmd/zrepl to libcstor/cmd/zrepl.
  • Adds the required auto makefiles to compile and generate zrepl binary.
  • Moves the build process(amd64 and arm) from cstor repo to libcstor repo.
  • Updates the downstream repo from openebs/cstor to openebs/istgt.
  • Update RELEASE.md and developer-setup.md with relevant changes.

NOTE:

  • Following is the dependency reslese openebs/cstor -> openebs/libcstor -> openebs/istgt.

Does this PR require any upgrade changes?:
No

If the changes in this PR are manually verified, list down the scenarios covered and commands you used for testing with logs:

  • Ran the test locally.
  • Verified by compiling and executing standalone binaries.
  • Built an image and used that image to provision cStor pools in the K8s environment.
  • Ran the Travis in local repo(check status here).

Any additional information for your reviewer?:
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

mittachaitu
mittachaitu commented Sep 7, 2020
View reviewed changes
build_image.sh Outdated Show resolved Hide resolved
mittachaitu added 4 commits September 8, 2020 20:48
chore(build): build and push images from libcstor
5946393 
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
This commit fixes the compilation issues in Travis
a37350b 
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
This commit updates the fio version and also fixes the build_image.sh…
db29cf2 
… script

Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
This commit adds license content to .am, .sh and Docker files
067fcb3 
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
mynktl
mynktl reviewed Sep 9, 2020
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
build_image.sh Outdated Show resolved Hide resolved
build_image.sh Outdated Show resolved Hide resolved
build_image.sh Outdated Show resolved Hide resolved
build_image.sh Outdated Show resolved Hide resolved
tests/cstor/script/test_uzfs.sh Outdated Show resolved Hide resolved
build_image.sh Outdated Show resolved Hide resolved
mittachaitu added 3 commits September 9, 2020 12:48
This commit incorporate the review comments
c19737a 
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
This commit adds semicolumn in Travis
d19a973 
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
This commit adds license file to ppce Makefile.am
35c939c 
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
vishnuitta
vishnuitta reviewed Sep 9, 2020
View reviewed changes
.travis.yml Show resolved Hide resolved
@vishnuitta vishnuitta mentioned this pull request Sep 9, 2020
Merged
7 tasks
vishnuitta
vishnuitta reviewed Sep 9, 2020
View reviewed changes
Makefile.am Show resolved Hide resolved
vishnuitta
vishnuitta reviewed Sep 9, 2020
View reviewed changes
docker/Dockerfile

LABEL org.label-schema.name="cstor"
LABEL org.label-schema.description="OpenEBS cStor"
LABEL org.label-schema.schema-version="1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there somethings that can be changed here? like name/description/version?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we moved the build process alone... So no need to change anything as of now

vishnuitta
vishnuitta reviewed Sep 9, 2020
View reviewed changes
Copy link
Contributor

@vishnuitta vishnuitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes need the .md file changes as well in both the repos.

pawanpraka1
pawanpraka1 reviewed Sep 9, 2020
View reviewed changes
Copy link
Contributor

@pawanpraka1 pawanpraka1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few licesne files are saying 2017-2019, can we update them.

.travis.yml Outdated Show resolved Hide resolved
@mittachaitu
Copy link
Author

few licesne files are saying 2017-2019, can we update them.

Actually they were written and last updated during that time frame so kept them as is... Should I need to update them to 2020/2018-2020?

@pawanpraka1
Copy link
Contributor

Actually they were written and last updated during that time frame so kept them as is... Should I need to update them to 2020/2018-2020?

as they are new file to this repo, we can add 2020 in the copyright.

mittachaitu added 2 commits September 9, 2020 16:17
This commit updates the .md files and incorporate review comments
0e70470 
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
This commit updates the licesne content from 2017-2019 to 2020
9999480 
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
@mittachaitu
Copy link
Author

Actually they were written and last updated during that time frame so kept them as is... Should I need to update them to 2020/2018-2020?

as they are new file to this repo, we can add 2020 in the copyright.

Done

@mittachaitu
Copy link
Author

these changes need the .md file changes as well in both the repos.

@vishnuitta updated the RELEASE.md and developer-setup.md files with new changes

mynktl
mynktl reviewed Sep 9, 2020
View reviewed changes
developer-setup.md Outdated Show resolved Hide resolved
developer-setup.md Outdated Show resolved Hide resolved
developer-setup.md Outdated Show resolved Hide resolved
developer-setup.md Outdated Show resolved Hide resolved
This commit incorporates the review comments
5e16dcd 
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
pawanpraka1
pawanpraka1 approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@pawanpraka1 pawanpraka1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@mittachaitu mittachaitu mentioned this pull request Sep 9, 2020
Merged
@pawanpraka1 pawanpraka1 merged commit c35e678 into openebs-archive:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishnuitta vishnuitta vishnuitta left review comments

@mynktl mynktl mynktl approved these changes

@pawanpraka1 pawanpraka1 pawanpraka1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mittachaitu @pawanpraka1 @vishnuitta @mynktl