Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cvc-controller): add support for policy/v1 PodDisruptionBudget #436

Merged
merged 1 commit into from
Sep 30, 2022
Merged

fix(cvc-controller): add support for policy/v1 PodDisruptionBudget #436

merged 1 commit into from
Sep 30, 2022

Conversation

niladrih
Copy link
Member

@niladrih niladrih commented Sep 27, 2022 •
edited
Loading

Signed-off-by: Niladri Halder niladri.halder26@gmail.com

Changes:

  • Add support for policy/v1 PodDisruptionBudget in the CVC controller. This is required because policy/v1beta1 is no longer supported in k8s v1.25.
  • Upgrade go version to 1.19, update k8s libs to 0.25.2.
  • Remove vendor directory.

@niladrih niladrih force-pushed the policy-v1 branch 2 times, most recently from 22b41fb to 9fd3fc2 Compare September 27, 2022 07:11
This was referenced Sep 27, 2022
Closed
Merged
@niladrih niladrih force-pushed the policy-v1 branch 2 times, most recently from 06c5b31 to 835fdeb Compare September 27, 2022 12:13
@github-actions github-actions bot requested a review from kmova September 27, 2022 12:13
vharsh
vharsh reviewed Sep 28, 2022
View reviewed changes
Copy link

@vharsh vharsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor change suggestions

build/cstor-webhook/cstor-webhook.Dockerfile Show resolved Hide resolved
pkg/controllers/cstorvolumeconfig/controller_base.go Outdated Show resolved Hide resolved
pkg/controllers/cstorvolumeconfig/controller_base.go Outdated Show resolved Hide resolved
pkg/controllers/cstorvolumeconfig/controller_base.go Outdated Show resolved Hide resolved
pkg/controllers/cstorvolumeconfig/pdb.go Outdated Show resolved Hide resolved
pkg/controllers/cstorvolumeconfig/volume_operations.go Outdated Show resolved Hide resolved
pkg/controllers/replica-controller/runner_test.go Show resolved Hide resolved
@niladrih niladrih force-pushed the policy-v1 branch 2 times, most recently from acbacf1 to d7b798a Compare September 28, 2022 10:19
@niladrih niladrih force-pushed the policy-v1 branch 4 times, most recently from da1907d to 7f6ccb1 Compare September 28, 2022 18:52
Ab-hishek
Ab-hishek approved these changes Sep 30, 2022
View reviewed changes
Copy link

@Ab-hishek Ab-hishek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/build.yml Outdated Show resolved Hide resolved
@niladrih
fix(cvc-controller): add support for policy/v1 PodDisruptionBudget
a70f18c 
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
@niladrih niladrih merged commit 4e239f0 into openebs-archive:develop Sep 30, 2022
@niladrih niladrih deleted the policy-v1 branch September 30, 2022 10:04
@ThomasBuchinger ThomasBuchinger mentioned this pull request Oct 24, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonatype-lift sonatype-lift[bot] sonatype-lift[bot] left review comments

@Ab-hishek Ab-hishek Ab-hishek approved these changes

@prateekpandey14 prateekpandey14 Awaiting requested review from prateekpandey14

@shubham14bajpai shubham14bajpai Awaiting requested review from shubham14bajpai

@sonasingh46 sonasingh46 Awaiting requested review from sonasingh46

@mittachaitu mittachaitu Awaiting requested review from mittachaitu

@kmova kmova Awaiting requested review from kmova

@pawanpraka1 pawanpraka1 Awaiting requested review from pawanpraka1

@avishnu avishnu Awaiting requested review from avishnu

@vharsh vharsh Awaiting requested review from vharsh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niladrih @vharsh @Ab-hishek