refact(upgrade, design): added status to versionDetails spec #2761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
kmova
approved these changes
Oct 4, 2019
vishnuitta
reviewed
Oct 4, 2019
| @@ -258,6 +258,15 @@ This design proposes the following key changes: | |||
| #this flag will be set to "no" when current != desired. | |||
| #after upgrading all the child objects, this will be changed to yes. | |||
| dependentsUpgraded: | |||
| #status gives the details about the reconciliation of the version | |||
| status: | |||
There was a problem hiding this comment.
LastUpdatedTime to know when the status really got updated
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
Signed-off-by: shubham <shubham.bajpai@mayadata.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: shubham shubham.bajpai@mayadata.io
What this PR does / why we need it:
This PR adds status to the versionDetails spec. To update the upgradeTask CR we need the status of the reconciliation happening in the controller. The status of versionDetails will provide that status to the upgrade job which can be patched to the upgradeTask CR.