fix(operator yaml): update deployment upgrade strategy as Recreate #2709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 14, 2019 21:00
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
… as recreate Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
kmova
reviewed
Aug 16, 2019
| @@ -12,6 +12,9 @@ metadata: | |||
| openebs.io/version: {{ .Values.release.version }} | |||
| spec: | |||
| replicas: {{ .Values.provisioner.replicas }} | |||
| strategy: | |||
| type: {{ .Values.provisioner.upgradeStrategy }} | |||
There was a problem hiding this comment.
Can this be changed to local PV provisioner. Also update the above replicas to use the localpvprovisioner (this has been fixed in upstream)
kmova
reviewed
Aug 16, 2019
| @@ -12,6 +12,9 @@ metadata: | |||
| openebs.io/version: {{ .Values.release.version }} | |||
| spec: | |||
| replicas: {{ .Values.webhook.replicas }} | |||
| strategy: | |||
| type: {{ .Values.webhook.upgradeStrategy }} | |||
| rollingUpdate: null | |||
There was a problem hiding this comment.
should rollingUpdate be set to null .. if the upgradeStrategy is set to Recreate. Having said that, should we even give this option to select the upgradeStrategy or hardcode it to "Recreate" ?
There was a problem hiding this comment.
We will hardcode it to Recreate
added 2 commits
August 16, 2019 20:44
Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
…llingUpdate Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
kmova
approved these changes
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mittachaitu sai.chaithanya@mayadata.io
This PR updates the control plane deployment upgrade strategy to
Recreate.When we set the upgrade strategy to
Recreatedeployment controller willmake sure during upgrade time(patching pod template spec) after deleting old pod
new pod with the changes will come to running state.
Which issue this PR fixes:
This PR fixes issue #2697