Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(autoprovisioning, blockdevice): add support to create cStor pools on sparse block device #2623

Merged
merged 1 commit into from
Jun 12, 2019
Merged

feat(autoprovisioning, blockdevice): add support to create cStor pools on sparse block device #2623

merged 1 commit into from
Jun 12, 2019

Conversation

mittachaitu
Copy link

@mittachaitu mittachaitu commented Jun 12, 2019 •
edited by AmitKumarDas
Loading

Add support to create sparse based or disk based cstor pools.
User needs to set spec.type type as sparse or disk.

Auto Provisioning:

  1. If cstor pools need to be created on top of sparse disks.
apiVersion: openebs.io/v1alpha1
kind: StoragePoolClaim
metadata:
  name: cstor-sparse
spec:
  name: cstor-sparse
  type: sparse
  maxPools: 3
  poolSpec:
    poolType: striped
    overProvisioning: false
  1. If cstor pools need to be created on top of disks attached to the node.
apiVersion: openebs.io/v1alpha1
kind: StoragePoolClaim
metadata:
  name: cstor-disk
spec:
  name: cstor-disk
  type: disk
  maxPools: 3
  poolSpec:
    poolType: mirrored
    overProvisioning: false

Signed-off-by: mittachaitu sai.chaithanya@mayadata.io

feat(autoprovisioning, blockdevice): add support to create cStor pool…
50520f9 
…s on sparse block device

Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
AmitKumarDas
AmitKumarDas approved these changes Jun 12, 2019
View reviewed changes
Copy link

@AmitKumarDas AmitKumarDas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Appreciate your time on explaining the stuff in the PR description

@AmitKumarDas AmitKumarDas merged commit b5c08f3 into openebs:master Jun 12, 2019
@ranjithwingrider
Copy link
Contributor

I prefer to type as block device instead of disk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prateekpandey14 prateekpandey14 prateekpandey14 approved these changes

@AmitKumarDas AmitKumarDas AmitKumarDas approved these changes

Assignees

@prateekpandey14 prateekpandey14

@kmova kmova

@mittachaitu mittachaitu

@ranjithwingrider ranjithwingrider

@vishnuitta vishnuitta

@gprasath gprasath

Labels
Eng team DOCS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mittachaitu @ranjithwingrider @AmitKumarDas @prateekpandey14 @kmova @vishnuitta @gprasath